Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: context, JSON Envelope & more #32

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Feature: context, JSON Envelope & more #32

merged 3 commits into from
Aug 19, 2021

Conversation

mrz1836
Copy link
Member

@mrz1836 mrz1836 commented Aug 19, 2021

  • Minor fixes, optimization

@mrz1836 mrz1836 self-assigned this Aug 19, 2021
@mergify mergify bot added the feature Any new significant addition label Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021 •
edited
Loading

Codecov Report

Merging #32 (dc3d3ab) into master (a2cf3fb) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head dc3d3ab differs from pull request most recent head c066b6d. Consider uploading reports for the commit c066b6d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   93.49%   93.43%   -0.07%     
==========================================
  Files           8        8              
  Lines         323      320       -3     
==========================================
- Hits          302      299       -3     
  Misses         15       15              
  Partials        6        6
Impacted Files Coverage Δ
definitions.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2cf3fb...c066b6d. Read the comment docs.

theflyingcodr
theflyingcodr approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@theflyingcodr theflyingcodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrz1836 mrz1836 marked this pull request as ready for review August 19, 2021 16:24
@mrz1836 mrz1836 merged commit 6f67547 into master Aug 19, 2021
@mergify mergify bot deleted the feature/context branch August 19, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theflyingcodr theflyingcodr theflyingcodr approved these changes

Assignees

@mrz1836 mrz1836

Labels
feature Any new significant addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrz1836 @theflyingcodr