-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass SUBREAPER to prctl patch and new desktop flavor #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
e2e-tini
branch
10 times, most recently
from
May 11, 2023 16:45
8aedbe2
to
5698ada
Compare
crazy-max
commented
May 11, 2023
Comment on lines
23
to
29
+ case PR_GET_CHILD_SUBREAPER: | ||
+ case PR_SET_CHILD_SUBREAPER: | ||
/* Some prctl options have no pointer arguments and we can pass on. */ | ||
return get_errno(prctl(option, arg2, arg3, arg4, arg5)); | ||
|
||
- case PR_GET_CHILD_SUBREAPER: | ||
- case PR_SET_CHILD_SUBREAPER: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tonistiigi @djs55 suggested patch looks to work indeed: https://github.com/tonistiigi/binfmt/actions/runs/4950685510/jobs/8854647906#step:8:9
Linux 90a30464b502 5.15.0-1037-azure #44-Ubuntu SMP Thu Apr 20 13:19:31 UTC 2023 aarch64 Linux
crazy-max
force-pushed
the
e2e-tini
branch
3 times, most recently
from
May 11, 2023 17:17
acdb7e6
to
6b66ebd
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
changed the title
e2e: run tini
pass SUBREAPER to prctl patch and new desktop flavor
Nov 30, 2023
tonistiigi
approved these changes
Nov 30, 2023
crazy-max
added a commit
to crazy-max/binfmt
that referenced
this pull request
Dec 23, 2023
pass SUBREAPER to prctl patch and new desktop flavor Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected to fail with current qemu (7.1.0): https://github.com/tonistiigi/binfmt/actions/runs/4938696451/jobs/8832456122?pr=134#step:6:49
@tonistiigi has bisected it to: qemu/qemu@220717a
series: https://lore.kernel.org/all/20211015041053.2769193-1-richard.henderson@linaro.org/T/