Simplify walker to use PatternMatcher instead of custom matching #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlehmann
force-pushed
the
doublestar
branch
from
2160aa4
to
e929e02
Compare
|
Rebased now that #107 is merged. |
coryb
approved these changes
Aug 20, 2021
This changes the pattern matching implementation in walker to use PatternMatcher, making it consistent with the "copy" code. This makes it support ** patterns as well, which formerly didn't work. The added benchmark shows the new implementation is slightly faster than the old one.
aaronlehmann
force-pushed
the
doublestar
branch
from
e929e02
to
9d0ab16
Compare
|
@tonistiigi: Do you see any compatibility concerns with this change? |
|
@tonistiigi: ping when you get a chance - don't want to break anything with this. |
tonistiigi
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the pattern matching implementation in walker to use
PatternMatcher, making it consistent with the "copy" code.This makes it support
**patterns as well, which formerly didn't work.The added benchmark shows the new implementation is slightly faster than the old one.
Opened on top of #107 - the first commit is from that PR, so only look at the second one.
Replaces #79
cc @coryb