Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t hang on diskwriter errors #16

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Don’t hang on diskwriter errors #16

merged 2 commits into from
Nov 17, 2017

Conversation

tonistiigi
Copy link
Owner

@tonistiigi
Don’t hang on diskwriter errors
e406d85 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
diskwriter: pass filter option
b9a08c4 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
AkihiroSuda
AkihiroSuda approved these changes Nov 17, 2017
View reviewed changes
Copy link
Collaborator

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although in future we should have timeout as well for avoiding general hang-up

@tonistiigi
Copy link
Owner Author

@AkihiroSuda Yes, but it is tricky to clean up properly when we don't know what is hanging. Atm it was hanging on the read() and there is no real good way to unblock that other than signal the sender to cancel(but that may not work for other errors).

@tonistiigi tonistiigi merged commit 3f70f82 into master Nov 17, 2017
@thaJeztah thaJeztah mentioned this pull request May 17, 2018
Closed
vdemeester pushed a commit to thaJeztah/docker that referenced this pull request Jun 5, 2018
@thaJeztah @vdemeester
Bump BuildKit and depencencies
e521f26 
Updates buildkit to current master (github.com/moby/buildkit): moby/buildkit@be6da00...7a4a2a2

Fixes build failures due to gRPC bumps;
18:54:28 vendor/github.com/moby/buildkit/session/filesync/filesync.go:185:8:warning: NewContext not declared by package metadata (gosimple)
18:54:28 vendor/github.com/moby/buildkit/session/filesync/filesync.go:69:13:warning: FromContext not declared by package metadata (gosimple)
18:54:28 vendor/github.com/moby/buildkit/session/filesync/filesync.go:185:8:warning: NewContext not declared by package metadata (interfacer)
18:54:28 vendor/github.com/moby/buildkit/session/filesync/filesync.go:69:13:warning: FromContext not declared by package metadata (interfacer)
18:54:28 vendor/github.com/moby/buildkit/session/filesync/filesync.go:69:13:warning: FromContext not declared by package metadata (unconvert)
18:54:28 vendor/github.com/moby/buildkit/session/filesync/filesync.go:185:8:warning: NewContext not declared by package metadata (unconvert)

Update vendored dependencies to match BuildKit:

- add github.com/grpc-ecosystem/grpc-opentracing dependency
- add github.com/opentracing/opentracing-go dependency
- downgrade github.com/pkg/errors to a tagged release: pkg/errors@v0.8.0...839d9e9
- github.com/containerd/continuity containerd/continuity@d8fb858...3e8f2ea
  - containerd/continuity#110 Add fstest.CreateSocket
- github.com/containerd/fifo containerd/fifo@fbfb6a1...3d5202a
  - Add apache license to files
- github.com/containerd/go-runc containerd/go-runc@4f6e87a...f271fa2
  - containerd/go-runc#37 runc: be able to get the full ps data (ps -f table)
  - containerd/go-runc#40 Add ConsoleSocket to RestoreOpts
- github.com/containerd/console containerd/console@2748ece...cb7008a
  - containerd/console#21 Add OpenBSD support
- github.com/syndtr/gocapability syndtr/gocapability@2c00dae...db04d3c
  - syndtr/gocapability#11 Add support for ambient capabilities
  - syndtr/gocapability#13 Fix issue moby#12: break too early
- golang.org/x/net golang/net@5561cd9...0ed95ab
- golang.org/x/text golang/text@f72d839...19e5161
- golang.org/x/time golang/time@a4bde12...f51c127
- github.com/tonistiigi/fsutil tonistiigi/fsutil@dea3a0d...93a0fd1
  - tonistiigi/fsutil#16 Don not hang on diskwriter errors
  - tonistiigi/fsutil#17 fix fd leak on send
  - tonistiigi/fsutil#18 avoid possible receiver panic/deadlock on sender error
  - tonistiigi/fsutil#20 receive: read stream to EOF on close
  - tonistiigi/fsutil#21 avoid not-exist error on walker
  - tonistiigi/fsutil#27 Generalize chtimes() implementation for non-linux platforms
  - tonistiigi/fsutil#28 walker: handle parents and subdirs in includepatterns

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonistiigi @AkihiroSuda