Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement chtimes on OpenBSD #23

Closed
wants to merge 1 commit into from
Closed

Implement chtimes on OpenBSD #23

wants to merge 1 commit into from

Conversation

unkaktus
Copy link
Contributor

No description provided.

@unkaktus unkaktus mentioned this pull request Feb 10, 2018
Closed
9 tasks
@thaJeztah
Copy link
Collaborator

ping @tonistiigi PTAL

@tonistiigi
Copy link
Owner

This could probably be in the _nolinux.go file with !linux build tag so there is no duplication with windows and darwin.

@unkaktus
Copy link
Contributor Author

@tonistiigi, it seems that chtimes is not implemented on darwin. 🤷‍♂️

@tonistiigi
Copy link
Owner

@nogoegst You mean os.Chtimes ? It definitely should be. https://github.com/golang/go/blob/6732fcc06df713fc737cee5c5860bad87599bc6d/src/os/file_posix.go#L5 https://github.com/golang/go/blob/6732fcc06df713fc737cee5c5860bad87599bc6d/src/os/file_posix.go#L139

So just to be clear, linux has own implementation. I think everything but linux can use os.Chtimes solution like suggested in here, instead of defining per-platform exceptions.

@unkaktus
Copy link
Contributor Author

unkaktus commented Mar 4, 2018

Closing in favor of #27.

@unkaktus unkaktus closed this Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unkaktus @thaJeztah @tonistiigi