Set custom values for azblob retries #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the reported 404's, I wonder if its a race condition and maybe we should retry on 404? Default error codes to retry on are:
|
Unless it gets 404 because it has been deleted internally. Then it would not come back on retry. That seems to be the case for at least one of the 404 logs we sent to Github for investigation. |
tonistiigi
approved these changes
Feb 28, 2025
tonistiigi
reviewed
Feb 28, 2025
cache_v2.go
Outdated
| @@ -45,8 +48,18 @@ func (c *Cache) reserveV2(ctx context.Context, key string) (string, error) { | |||
| return cr.SignedUploadURL, nil | |||
| } | |||
|
|
|||
| var clientOptions = &blockblob.ClientOptions{ | |||
This just allows more retries with a bigger backoff. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
set_azblob_retries
branch
from
6f4b459 to
3136d0f
Compare
renovate bot
added a commit
to hetznercloud/csi-driver
that referenced
this pull request
Mar 5, 2025
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/moby/buildkit](https://redirect.github.com/moby/buildkit) | `v0.20.0` -> `v0.20.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>moby/buildkit (github.com/moby/buildkit)</summary> ### [`v0.20.1`](https://redirect.github.com/moby/buildkit/releases/tag/v0.20.1) [Compare Source](https://redirect.github.com/moby/buildkit/compare/v0.20.0...v0.20.1) Welcome to the v0.20.1 release of buildkit! Please try out the release binaries and report any issues at https://github.com/moby/buildkit/issues. ##### Contributors - Tõnis Tiigi - Akihiro Suda - CrazyMax ##### Notable Changes - Fix panic during CDI manager initialization. [#​5769](https://redirect.github.com/moby/buildkit/issues/5769) [cncf-tags/container-device-interface#254](https://redirect.github.com/cncf-tags/container-device-interface/issues/254) - Fix gRPC message size when writing SBOMs. [#​5798](https://redirect.github.com/moby/buildkit/issues/5798) [containerd/containerd#11457](https://redirect.github.com/containerd/containerd/issues/11457) - Update azblob client retries for GitHub Actions cache backend. [#​5797](https://redirect.github.com/moby/buildkit/issues/5797) [tonistiigi/go-actions-cache#33](https://redirect.github.com/tonistiigi/go-actions-cache/issues/33) - Embedded binfmt emulators in the release image have been updated to QEMU v9.2.2. [#​5808](https://redirect.github.com/moby/buildkit/issues/5808) - Update documentation and examples for rootless mode. [#​5765](https://redirect.github.com/moby/buildkit/issues/5765) ##### Dependency Changes - **github.com/containerd/containerd/v2** v2.0.2 -> v2.0.3 - **github.com/tonistiigi/go-actions-cache** [`1a5174a`](https://redirect.github.com/moby/buildkit/commit/1a5174abd055) -> [`3e9a664`](https://redirect.github.com/moby/buildkit/commit/3e9a6642607f) - **tags.cncf.io/container-device-interface** v0.8.0 -> v0.8.1 Previous release can be found at [v0.20.0](https://redirect.github.com/moby/buildkit/releases/tag/v0.20.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/hetznercloud/csi-driver). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODUuNCIsInVwZGF0ZWRJblZlciI6IjM5LjE4NS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just allows more retries with a bigger backoff.
Just taking a stab at values for this.
Defaults without this change are:
3 retries, 4 second delay, 60s max retry delay.