Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xx-cargo: fix vendor for pkg-config and clang #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jprendes
Copy link

This should fix #107 .

@tonistiigi
Copy link
Owner

Does https://github.com/tonistiigi/xx/pull/90/files#diff-569650ba88094e023d2e66147417439ceeba349a6925868177e4628758830d3e do the same thing or are the functional differences?

This XX_VENDOR, XX_RUSTUP switching is generally a bit of a mess and would need some docs that make the behavior clear in some follow-up.

@thaJeztah
Copy link
Contributor

Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@milas
Copy link

milas commented Oct 8, 2023

I ran into this today while trying to build something that uses the openssl-sys crate, which wants to use pkg-config. (Going from amd64 -> aarch64 in my case.)

Swapping to @jprendes fork worked, while #90 did not (the Rust/WASM PR branch fails with "pkg-config has not been configured to support cross-compilation" and has $TARGET = aarch64-unknown-linux-gnu).

@tonistiigi
Copy link
Owner

Discussed this with @crazy-max and he will work on a regression test for this. Without regression tests it is very hard for any change in these XX_VENDOR overrides not to break some combination of the triples that clang/rust/pkg-config expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xx-cargo fails with crates using pkg-config in build scripts
4 participants