Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loong64 support #139

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

add loong64 support #139

wants to merge 8 commits into from

Conversation

yzewei
Copy link

@yzewei yzewei commented Jan 6, 2024

Get the latest Commit, the latest PR
The previous PR add loong64 support

moby/buildkit#4392

I'm sorry to complete this PR so late. I am busy some time ago. I have only been free now. Thank you very much for your attention!

Let me give you the lowdown once again: Loongarch, also known as Loongarch, is a badass RISC-style Instruction Set Architecture (ISA). It's all the rage in the open-source community and has been rocking long-term support.

@yzewei
Copy link
Author

yzewei commented Jan 6, 2024

@tonistiigi @crazy-max The PR of add loong64 support has been moved here

@yzewei yzewei force-pushed the master branch 2 times, most recently from 4ae1547 to 2eff431 Compare January 8, 2024 02:19
src/test_helper.bash Outdated Show resolved Hide resolved
src/xx-apk Outdated Show resolved Hide resolved
@yzewei
Copy link
Author

yzewei commented Jan 10, 2024

Update test-clang.bats is currently effective

@yzewei
Copy link
Author

yzewei commented Jan 10, 2024

golang support loong64 from 1.19

docker-bake.hcl Outdated Show resolved Hide resolved
docker-bake.hcl Outdated Show resolved Hide resolved
@yzewei
Copy link
Author

yzewei commented Jan 18, 2024

ptal

docker-bake.hcl Outdated Show resolved Hide resolved
docker-bake.hcl Outdated Show resolved Hide resolved
Copy link
Collaborator

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still the whitespace issue to solve in the bake file. Can you also squash your commits please?

Signed-off-by: yzewei <yangzewei@loongson.cn>
@yzewei yzewei requested a review from crazy-max January 18, 2024 11:05
Signed-off-by: yzewei <yangzewei@loongson.cn>
@yzewei
Copy link
Author

yzewei commented Jan 18, 2024

I don’t figure out why there is an assertion failure when using loong64 in debian and ubuntu, and not all versions will do this.
Maybe we can only operate loong64 on the sid version of the hellogo function?

@yzewei
Copy link
Author

yzewei commented Jan 18, 2024

I don’t figure out why there is an assertion failure when using loong64 in debian and ubuntu, and not all versions will do this. Maybe we can only operate loong64 on the sid version of the hellogo function?

The golang installed is 1.15 does not support loong64 and changed to 1.19

@tonistiigi
Copy link
Owner

The golang installed is 1.15 does not support loong64 and changed to 1.19

The code you changed is under "buster-backports" condition

Signed-off-by: yzewei <yangzewei@loongson.cn>
@yzewei
Copy link
Author

yzewei commented Jan 19, 2024

When GOARCH=loong64, add prerequisites to the testenv() function to judge the Golang version

Copy link
Owner

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to see how this would be useful in current form. No packages seem to install in debian. No C-based build seems to work in any distro, in debian because packages can't be installed and in old Alpine 3.11 because there doesn't seem to be any supported linker.

Despite most tests being disabled, the CI still looks quite red.

src/xx-apt Outdated
if [ "$TARGETARCH" = "loong64" ] && [ "$(xx-info vendor)" = "debian" ]; then
apt-get update
apt-get install -y debian-ports-archive-keyring
echo "deb [ arch=loong64 ] http://ftp.ports.debian.org/debian-ports sid main
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to get any packages to install in sid. This may be temporary error, but looks like there are conflicts between architectures.

Eg. difference of versions of gcc-13-base seems to cause issues.

src/xx-apt Outdated Show resolved Hide resolved
src/test-clang.bats Outdated Show resolved Hide resolved
src/xx-info Outdated Show resolved Hide resolved
src/xx-cargo Outdated Show resolved Hide resolved
Signed-off-by: yzewei <yangzewei@loongson.cn>
@yzewei
Copy link
Author

yzewei commented Jan 29, 2024

It's hard to see how this would be useful in current form. No packages seem to install in debian. No C-based build seems to work in any distro, in debian because packages can't be installed and in old Alpine 3.11 because there doesn't seem to be any supported linker.

Despite most tests being disabled, the CI still looks quite red.

Can I adapt to debian first, alpine is waiting for the official community to start loadarch into the upstream and modify it?

Signed-off-by: yzewei <yangzewei@loongson.cn>
@yzewei
Copy link
Author

yzewei commented Feb 18, 2024

Due to the fact that the alpine community has not yet accepted the loongarch architecture, I have temporarily removed the build testing under alpine. After alpine community receives the loongarch architecture, I will start ci-testing.

@yzewei
Copy link
Author

yzewei commented Mar 11, 2024

It seems that there are some problems with the cargo part of the arm64 and ppc64 architecture test in the debian: sid test. Can you see what the situation is? @tonistiigi
Error: debian:sid

@yzewei
Copy link
Author

yzewei commented Mar 18, 2024

https://github.com/tonistiigi/xx/actions/runs/7947422441/job/22165142567?pr=139#step:5:1607
https://github.com/tonistiigi/xx/actions/runs/7947422441/job/22165142567?pr=139#step:5:1563
https://github.com/tonistiigi/xx/actions/runs/7947422441/job/22165142567?pr=139#step:5:1429
https://github.com/tonistiigi/xx/actions/runs/7947422441/job/22165142567?pr=139#step:5:1279
https://github.com/tonistiigi/xx/actions/runs/7947422441/job/22165142567?pr=139#step:5:1127

Why does this happen on CI?
I haven't had any problems with my project, https://github.com/yzewei/xx/actions/runs/7947440228/job/21696264971

@yzewei
Copy link
Author

yzewei commented Mar 18, 2024

@tonistiigi Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants