ld: update ld64 and dependencies #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure triple-clang and xx-clang have the same behavior. For some reason, triple-clang does not load the config automatically anymore starting from debian trixie. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
ld64-update
branch
from
3d93560 to
38acd46
Compare
tonistiigi
commented
Jan 8, 2024
| inherits = ["_ld-base"] | ||
| matrix = { |
There was a problem hiding this comment.
There was something off in here. ld64 is not built per target architecture like binutils/ld is, only per runner architecture.
There was a problem hiding this comment.
It takes ~50m to build on the same runner, we should look at distributing each built platform on a dedicated runner:
There was a problem hiding this comment.
SGTM but can be follow-up
| ARG LIBTAPI_VERSION | ||
| RUN git clone https://github.com/tpoechtrager/apple-libtapi --depth 1 -b ${LIBTAPI_VERSION} | ||
| WORKDIR ./apple-libtapi | ||
| RUN --mount=target=/tmp/libtapi-cmake-args.patch,source=libtapi-cmake-args.patch \ | ||
| git apply /tmp/libtapi-cmake-args.patch | ||
| RUN apk add --no-cache gcc g++ | ||
| RUN NOMAKE=1 CMAKE_EXTRA_ARGS="$(xx-clang --print-cmake-defines)" ./build.sh && \ | ||
| RUN NOMAKE=1 CMAKE_EXTRA_ARGS="$(xx-clang --print-cmake-defines) -DCMAKE_CXX_FLAGS=-D_LARGEFILE64_SOURCE" ./build.sh && \ |
There was a problem hiding this comment.
Fails with missing lseek64 otherwise.
| codesign -f -s - "$out" |
There was a problem hiding this comment.
Technically I don't think this is needed anymore as new ld64 can do ad-hoc signatures automatically.
tonistiigi
commented
Jan 8, 2024
| make -j $(nproc) -C ld64 && \ | ||
| xx-verify --static ld64/src/ld/ld | ||
|
|
||
| FROM --platform=${BUILDPLATFORM} alpine:${ALPINE_VERSION} AS sigtool-base |
There was a problem hiding this comment.
Because of this wrong stage order the latest prebuilt ld64 version is missing these files and broken
crazy-max
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.