xx-apt: add special case for ubuntu repo switch #49
Conversation
tonistiigi
force-pushed
the
tonistiigi/ubuntu-apt
branch
2 times, most recently
from
e0a9e79
to
6b38e1c
Compare
tonistiigi
force-pushed
the
tonistiigi/ubuntu-apt
branch
from
6b38e1c
to
ebf3623
Compare
tonistiigi
force-pushed
the
tonistiigi/ubuntu-apt
branch
4 times, most recently
from
8184d5b
to
c53061f
Compare
|
|
||
| if echo "$p" | grep -E "^(deb|deb-src) "; then | ||
| case "${nativearch}" in | ||
| amd64 | 386) |
There was a problem hiding this comment.
This fixes all active rules to the current arch group and adds a duplicate rule for the additional group.
Alternative would be to set current rules only to the current native arch and add detect the ubuntu distro and add only the known rules for that arch, each time fixed to individual arch.
Maybe the second one is better. wdyt? @crazy-max
There was a problem hiding this comment.
Alternative would be to set current rules only to the current native arch and add detect the ubuntu distro and add only the known rules for that arch, each time fixed to individual arch.
Yes, the second solution with native arch might be better in the long run.
There was a problem hiding this comment.
Let's merge this one. I'll make a new PR and we can see if it actually improves.
|
I removed 18.04 from CI. The llvm version is way too low for anything meaningful. |
I've started the follow-up for #52 and on fedora 35 (stable) llvm version is quite new in my case 13.0.0~rc1. |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
tonistiigi/ubuntu-apt
branch
from
c53061f
to
25bdc8b
Compare
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com