New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added safeguard against deleting last extension with disallowed pubkey, fixed ext operation prefix clashing bug and adjusted code style #16

Merged

oleganza merged 3 commits into tonkeeper:main from Skydev0h:skydev/del-ext-safeguard

Feb 23, 2024

Contributor

Skydev0h commented Feb 23, 2024 •

edited

Loading

(annotated by @oleganza)

Bug fixes and improved tests.
Minor changes to the coding conventions or style for consistency and readability.
Addressed and resolved a bug related to the theft of a prefix, which was highly improbable to occur. @behrang mentioned the bug in a discussion group, highlighting its occurrence probability as 2^-32, making it impossible to add an extension with a specific 32-bit address prefix while adhering to protocol.

Skydev0h added 3 commits

February 22, 2024 01:52


          Added safeguard against deleting last ext with disabled key (need tests)

8661ce2


          Fix prefix clashing bug and adjust code style (reported by @behrang)

4458be0


          Fixed tests and added cases for deleting last ext with disallowed pubkey

51358ad

oleganza approved these changes

View reviewed changes

oleganza merged commit fa1b372 into tonkeeper:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet