Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polishing TF-improvements to the w5 contract #24

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Polishing TF-improvements to the w5 contract #24

merged 4 commits into from
Jul 3, 2024

Conversation

Skydev0h
Copy link
Contributor

  1. Internal messages can use any send_mode
  2. Action list verification accounts for exotic cells
  3. Moved signature_auth_disable to separate variable from seq_no sign
  4. Removed unneccessary (and maybe even harming) shortcuts
  5. Deduplicated process_signed_xxx code into single fun
  6. Plugins now bound to same workchain as the wallet, no packing

Skydev0h and others added 4 commits June 14, 2024 18:30
@Skydev0h
Some improvements and changes to the contract
92471dd 
1) Internal messages can use any send_mode
2) Action list verification accounts for exotic cells
4) Removed unneccessary (and maybe even harming) shortcuts
5) Deduplicated process_signed_xxx code into single fun
@Skydev0h
Plugins now bound to same workchain as the wallet, no packing (6)
7d1d144
@Skydev0h
Moved signature_auth_disable to separate variable from seq_no sign (3)
1f9b0a3
@Skydev0h @p0lunin
Fix getExtensionsArray() method when address hash starts with 00
a210caa 
Co-authored-by: Dmytro Polunin <dmytro.polunin@gmail.com>
@Skydev0h
Copy link
Contributor Author

Added fix that was done in #18 (Thanks, @p0lunin!)

@Totemancer
Copy link

Added fix that was done in #18 (Thanks, @p0lunin!)
Is this pull will be the final contract?

This compiles to (short)
b5ee9c7241021301000226000114ff00f4a413f4bcf2c80b0102012004020102f203011420d728239b4b3b74307f0f020148

YjVlZTljNzI0MTAyMTMwMTAwMDIyNjAwMDExNGZmMDBmNGE0MTNmNGJjZjJjODBiMDEwMjAxMjAwNDAyMDEwMmYyMDMwMTE0MjBkNzI4MjM5YjRiM2I3NDMwN2YwZjAyMDE0OA==
https://github.com/tonkeeper/tonkeeper-ton/blob/master/src/wallets/WalletContractV5.ts#L81

I assume is not advised to use this yet. Do you have an ETA for when we can start using Final V5?

@Skydev0h
Copy link
Contributor Author

Skydev0h commented Jun 20, 2024 •
edited
Loading

There are some more internal reviews and procedures that need to be done before v5 will be finalized.
If neccessary, there may be some additional changes to the code and / or the structure.

Unfortunately I cannot give any estimates, therefore I advice you to keep an eye on this PR and TK news!

@KuznetsovNikita KuznetsovNikita merged commit a210caa into tonkeeper:main Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noroz-77 Noroz-77 Noroz-77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Skydev0h @Totemancer @Noroz-77 @KuznetsovNikita