[W5OC] Skydev's challenge entry ("conservative" edition) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that removing difference automatically closes the PR, so I will have to force-push the changed code over the dummy commit 😓 |
|
The code has been published! |
siandreev
reviewed
Oct 27, 2023
siandreev
reviewed
Oct 27, 2023
siandreev
reviewed
Oct 27, 2023
siandreev
reviewed
Oct 27, 2023
siandreev
reviewed
Oct 27, 2023
siandreev
reviewed
Oct 27, 2023
siandreev
reviewed
Oct 27, 2023
|
@siandreev fixed the issues mentioned in the review comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "conservative" edition of my contest entry.
The conservativeness of it is that it does not involve modification of the TVM Assembler (
Asm.fif), but by it, it loses a considerable amount of possible optimizations, since this change very well synergizes with other optimizations (without them such extent would not be possible because of code size constraints), and I'd like to invite you to take a look at the "radical" edition here: #4.You can take a look at all the optimizations with detailed explanations of each optimization and commit at the Improvements log document (that is also now linked from the README page, that also now has a special section about the contest).
Also, an undoubtable GitHub activity history is provided as a time precedence guarantee that the optimizations are original and are not copy-cated.