Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you make the r look better? #601

Closed
pakLebah opened this issue May 22, 2018 · 28 comments
Closed

Can you make the r look better? #601

pakLebah opened this issue May 22, 2018 · 28 comments
Milestone

Comments

@pakLebah
Copy link

pakLebah commented May 22, 2018

Fira Code is the best font for writing code (programming). My only complaint is the r looks weird compare to other letters. Can you make the r looks better? I mean make it as sans-serif like the other letters, instead of being the only serif letter in the group.

Thank you.

@tonsky
Copy link
Owner

tonsky commented May 22, 2018

It has its form for legibility reasons. Maybe I’ll return alternative form as a stylistic subset one day, thanks for the reminder!

@pakLebah
Copy link
Author

IMO, the current r is anything but legibility. Just look at the provided codes in the readme. The r seems out of place. I even notice it since the first time I tried this font. I love its ligatures though. So, I just ignore it but somehow it still annoys me. I wish I could replace it myself with something from Consolas or something. 😊

@abductedMind
Copy link

The "r" is not particularly in need of increased legibility. Currently it stands out like a sore thumb. My cooworker when shown Fira said hmm....looks cool...oh wait! Thats what the "r" looks like? Nope not doing it. Nevermind. I'm in the same camp.

@whenov
Copy link

whenov commented Jun 7, 2018

Noto Sans Mono seems has the same problem.

@bynux-gh
Copy link

bynux-gh commented Oct 20, 2018

This issue is the one thing keeping me from using Fira Code as my main font. The lowercase r throws off the whole aesthetic. I've never had any problem with r being legible, except maybe in handwriting.

We need either a new r glyph or an alt-style with a sans-serif r. I scratched together a possible alternative in FontForge for the Regular weight:
2018-10-20-014748_1920x1080_scrot

If I have time this weekend, I'll work on the other weights and submit a pull request.

@j-f1
Copy link
Contributor

j-f1 commented Oct 20, 2018

@brilliantly-insane How about dropping the serif on the left side of the r too?

@bynux-gh
Copy link

bynux-gh commented Oct 20, 2018

@j-f1 Agreed; thought it might work with the l and J characters, for example, but it doesn't work for the r.

@pakLebah
Copy link
Author

Yup. I think the r should be made completely sans-serif. And please make it the same for every style (italic, bold, light, etc). Thank you. 😊

@fatjoem
Copy link

fatjoem commented Oct 22, 2018

The r is keeping me and my colleagues from using this font. I never encountered someone that actually likes the current r in this font.

@kumarharsh
Copy link

FWIW, the i is also in the serif style.

image

@abductedMind
Copy link

abductedMind commented Dec 18, 2018

There are a few other traditional serifs such as the i j L, however the r is unusual for an r. Perhaps it would look right if the curved width was 10% wider or we had been used to seeing it in other fonts (there may be a font out there that does have this serif? But I don't know one off the top of my head). Almost all serifs are horz (in this font), the r has the only one vertical. I mean if for the r why not for the c as well? or s or z or 7? The point is that the r stands out. The r is not harmonious.

@tonsky
Copy link
Owner

tonsky commented Dec 18, 2018

It isn’t. Originally r didn’t have serifs. Those were added because people complained about low legibility. r without serifs used to look like lowercase i. If you dig deep enough I guess you can find the original r in oldest Fira Mono files

@fatjoem
Copy link

fatjoem commented Dec 18, 2018

That's hard to believe really. How many people complained? Whomever I ask, they prefer using another font instead of Fira, because of the serifs in Fira r.

@tonsky
Copy link
Owner

tonsky commented Dec 18, 2018

mozilla/Fira#49

@abductedMind
Copy link

abductedMind commented Dec 23, 2018

Yes, important link above. Note that people immediately complained about the result in that issue. Its a real SHAME that an "issue" with the r was the resolved this way, when this issue should be an issue for many other mono-spaced fonts, yet its not? IMO: It wasn't a real issue then, and now we have an ugly r.

@gphilipp
Copy link

gphilipp commented Jan 22, 2019

I didn’t adopt Fira because of the r too, I just... can’t. That’s a pity because everything is so good but this spoils it. Maybe if I used it for several months I could get used to it, but each time I tried I just kept staring at those r letters.

@OldStarchy
Copy link

@diplomatic-dev how did you go with that?

@byoungju94
Copy link

I think fira code is the best font for intellij and windows console!

but i agree "r" looks awkward...

@al2me6
Copy link

al2me6 commented Feb 22, 2019

Another viewpoint (possibly unpopular):

To me, the r is the one glyph that truly sets the font apart. While it is indeed quirky and unconventional, it's also one of the things that make the font instantly recognizable.

However, that is not to say the glyph looks good from a useability perspective. I feel like removing only the offending serif and keeping the body in the same form as the current i would be the best compromise to make.

@alexdreptu
Copy link

I'm mainly using Source Code Pro / Hasklig and I tried so many times to use Fira Code but couldn't even manage to have it set for a few days. It has many good parts but the r makes the code look unpleasant when I scan it with my eyes. This single glyph can make whole lines of code look displeasing.

@kisarid
Copy link

kisarid commented May 10, 2019

+1, please add a sans r. Fira Code would be my favorite font if it wasn't for that r

@radu-b
Copy link

radu-b commented Jun 25, 2019

I stopped seeing it after a week, now it looks just normal. The author, having looked at it for years, must think: what do these people have against a perfectly normal r?

@steebchen
Copy link

Am I the only one who likes the r?

@ollicle
Copy link
Contributor

ollicle commented Jul 12, 2019

@steebchen you are not alone. I don’t believe it needs defending.

@MartinHaeusler
Copy link

I vote for a truly sans-serif version of Fira Code. It has become my favourite coding font, but the serifs look extremely odd, even more so on a 4k monitor with more pixels available for font rendering. Most notably, r and ì could use a sans-serif treatment, maybe l (lowercase L) too. g is also a bit too playful for my taste.

@tonsky tonsky added this to the 1.208 milestone Aug 27, 2019
tonsky added a commit that referenced this issue Sep 2, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@tonsky tonsky closed this as completed Sep 3, 2019
@mawkler
Copy link

mawkler commented Jan 11, 2021

How do I easiest get the version of FiraCode with sans-serif r? Is it exclusively through stylistic sets, or is there an already patched version of the font available somewhere? I'm asking because my editor currently doesn't have built-in support for stylistic sets.

@alexeyten
Copy link

How do I easiest get the version of FiraCode with sans-serif r?

There's a tool OpenType Feature Freezer.

With it you could patch the font yourself.

E.g. pyftfeatfreeze -f SS01 -S FiraCode-Regular.ttf FiraCodeSS01-Regular.ttf

@mawkler
Copy link

mawkler commented Jan 11, 2021

@alexeyten Thanks, I'll give that a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests