-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pipe | shorter #843
Comments
It became taller to match full block height in progressbar:
Maybe it’s not such a good idea. |
Actually now I’m thinking that I can detect that specific case and alter the height in that case only |
I think a proper progress bar should use U+2502 instead of U+007C anyway |
Tell that to pip authors :) |
What about when the bar isn’t all the way full?
|
Yeah, bad idea. Shame :( |
I actually quite liked it last time I used a font with vertical bars this long, specifically for haskell's guards, and I like it here as well: (github file attachment doesn't seem to work for me at the moment, so here's an imgur link) If you end up removing it, maybe consider leaving it in as a stylistic set, I would appreciate it. |
Looks great in your screenshot. Thanks for that use-case! |
Another vote for keeping the bar full-height. |
Actually long bar was looking weird in Rust lambdas - |
Thanks for the good work. But in my personal opinion, the new
|
seems too tall in normal code. Now the||
is way taller than&&
, which seems inconsistent. Also, some related ligatures is inconsistent to this taller|
, like|=
EDIT: I'm talking about the ASCII symbol
|
(U+007C) instead of the BOX DRAWINGS LIGHT VERTICAL│
(U+2502). In v2.0, the|
(U+007C) becomes taller, which I think is a mistake.Originally posted by @blahgeek in #449 (comment)
The text was updated successfully, but these errors were encountered: