Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<?= in PHP triggers the ?= ligature, looking weird #850

Closed
tabatkins opened this issue Sep 24, 2019 · 1 comment
Closed

<?= in PHP triggers the ?= ligature, looking weird #850

tabatkins opened this issue Sep 24, 2019 · 1 comment

Comments

@tabatkins
Copy link

<?= $foo ?> will immediately output the expression in the tags in PHP (it's a shorthand for <?php echo($foo) ?>).

Unfortunately, the ?= ligature fires here, making the opener look a little weird.

Could we either disable the ?= ligature when it's immediately preceded by <, or add ligatures for PHP's <?/<?php/<?=/?>?

(Thanks so much for this font, btw!)

@tonsky
Copy link
Owner

tonsky commented Sep 25, 2019

Thanks! That’s the valid concern, I’ll try to fix it!

@tonsky tonsky added this to the 3 milestone Sep 25, 2019
Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 13, 2020
@tonsky tonsky closed this as completed in f51adc1 Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants