-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is ◻ instead of [] a good idea? #92
Comments
I personally like it. The unicode square you have in the title is quite a bit smaller than the bracket-square that Fira Code provides. |
It really threw me off at first as well. Is there an easy way to remove it from the font file? |
Agreed, I find it very eye-catching and it doesn't quite recall an empty vector to me. |
+1 on having an option to remove it if it's possible. |
Maybe there should be a subtle break between the two |
The square for [ ] confuses me too. |
Java uses it as a dimension symbol. |
The box for [] always makes me think it's just a missing unicode character box. |
@surrealist in some languages, such as Haskell, [] is a distinct object with its own identity. That being said, I agree with @weavejester that a subtle break between the two [] would be useful. |
+1 , agreed with @tobia |
Diagonal break number two looks beautiful. El lun., 18 de jul. de 2016 a la(s) 14:32, Juerd Waalboer <
GitHub / Twitter: @joelalejandro |
i support the diagonal broken version. [] is quite frequent in PHP and i thought it was the "unicode done got knackered" character and not legit code. |
Oooh, how subtle! 👍 for the second variation. |
+1 with the second one too. Goes great with Fira's subtly tapered ends. |
Diagonal break will likely not be particularly visible on smaller font sizes. |
@Juerd +1 |
@Juerd 👍 |
I agree that I would just remove it from the ligatures. Or maybe render it as |
i like both the / cut [] and the [·] ideas. |
|
@Juerd +1 |
@Juerd +1, that second one definitely looks like the best way to do this |
Personally, I think the diagonal idea isn't good; it implies there's some asymmetry involved, and that's not true for many, many cases (all cases?). I think the dot idea is also suboptimal. The problem is that [] is used to mean many different things in many different languages. Adding something in the middle just isn't going to work across many different contexts. You see that in several comments; people are talking about "empty" - but there is nothing about [] that implies empty. Or that doesn't imply empty. Emptiness just isn't a concept involving []. That's my problem with the box, too - the box is very, very different than two matching square braces. It's making invalid semantic assumptions. |
@banshee but look at the <= and >= operators. part of it is visual flare. that is what makes the [/] work. |
I personally think the [ ] ligature should go away. The reasoning behind this is the following. So +1 for this request. |
Turns out it's super easy to remove []'s ligature, so if you love the font and just want [] gone, it's straightforward. I did it and submitted a pull request, or you just just build it yourself from my fork (https://github.com/banshee/FiraCode/tree/remove_leftbracket_rightbracket_ligature) |
@banshee can you build them (ttf at least) and put them somewhere for us to download? Many of us don't have Glyphs or a Mac to build it on. |
You don't actually need a mac, you can build them just by installing Clojure and then figuring out which Clojure plugins to install then if you're on Windows installing the new Ubuntu support in Windows 10 so you get bash and then... Hmm. OK, here are the font files :-) https://github.com/banshee/FiraCode/releases/tag/noLigs I want to be clear - I think FiraCode is fantastic, and I think it's totally fair to call what I did a "nasty hack job." I'd love for my little branch to die off quickly. I'd even like a nicely done ligature that didn't look like a box, but my skills don't include making fonts look good. |
@banshee any chance of ttf versions? OTF can't be used in text tool windows like PowerShell/Command prompt :/ |
Gosh you’re boring. I’ve just released 1.201 version where |
@tonsky previous comment was fun of the year[2016] 😄 |
Improve code climate
It makes empty list/vector look like some entirely new object instead of just a list without any elements.
The text was updated successfully, but these errors were encountered: