Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datalog-console): respond to datalog-console messages in browser #395

Closed

Conversation

groundedsage
Copy link

Basic implementation for Datalog Console #394

@tonsky
Copy link
Owner

tonsky commented May 20, 2021

Thank you for the patch! Datalog-console looks awesome!

Not saying your approach is wrong, just need more context and make sure we looked at all options. This is what I am curious about:

  1. Is there a way for initialization code to not be in the core?
  2. You are hooking up conn creation. What do you think should happen if user has multiple conns?
  3. Same question, but if user just uses db and db-with?

@groundedsage
Copy link
Author

Glad you like the Datalog Console.

We are aware that there is quite a few things we need to consider and this is just to get the ball rolling. These are of course very good questions.

I think we could move the code outside of core and have some utility for registering the database. Not sure exactly what that would look like yet. We are open to suggestions on what could be done here if you have any.

@tonsky
Copy link
Owner

tonsky commented May 23, 2021

What if you just insert something like

datalog_console.show_db(db);

? What would be limitations of that? Usability-wise, convenience-wise?

@groundedsage
Copy link
Author

We are currently doing a lot of improvements to the Datalog Console and it will now be available as a separate library. I am closing this pull request and will open another one for a README update when v1 is released. So developers can find dev tooling that works with Datascript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants