Fragments support #167
Closed
Fragments support #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really looking forward to this. Wish I had the time to help you out with more tests. Maybe this weekend. |
|
I think we're close to fully support them. Need more manual/automated testing I think. Especially the case with several top fragments level. Maybe others. |
|
What's the status for this? |
|
I personally haven't had time to finish the PR. I'm sure it's close though,
if you want to take a look.
…On Sat, Mar 23, 2019, 11:55 AM Peter Strömberg ***@***.***> wrote:
What's the status for this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#167 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEt3q7MKvmfblXBoS2NdQ63xKZMhpZxks5vZgg8gaJpZM4UW65R>
.
|
|
Hello 👋 New maintainer here. We'll most likely pull in Sablono into the repo some time in the future (see #198), so this will be addressed later for both JS and JVM targets. The plan is to have |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time for real. My simple implementation seems to work well (at least it passes the test).
This needs more tests maybe, examples and Readme update at least.