Make extension compatible with other ecosystems by using the generic state API #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
window object VSCode seems to have a fallback/binding of this function on the window object in the WebView, however THeia does not have this binding. Theia does however provide the same API as described in https://code.visualstudio.com/api/extension-guides/webview#persistence This closes tonybaloney#274
xoriath
force-pushed
the
state-from-vscode-and-theia
branch
from
419aa59 to
12c1541
Compare
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=========================================
+ Coverage 8.25% 8.35% +0.10%
=========================================
Files 3 3
Lines 642 634 -8
Branches 99 90 -9
=========================================
Hits 53 53
+ Misses 589 581 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tonybaloney
approved these changes
Oct 19, 2022
tonybaloney
changed the title
tonybaloney
added a commit
that referenced
this pull request
Feb 26, 2023
Get the state API either from VsCode or Theia, and check if it is und…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…efined before accessing it
This closes #274