Updated name.ts #293
Merged
Updated name.ts #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added a few new pet names of snake, duck, and crab.
tonybaloney
requested changes
Oct 26, 2022
src/common/names.ts
Outdated
| 'Medusa', | ||
| 'Naga', | ||
| 'Severus', | ||
| 'Sir Hiss', |
There was a problem hiding this comment.
Sir Hiss already appears on line 363, please remove
src/common/names.ts
Outdated
| @@ -287,6 +287,33 @@ export const CRAB_NAMES: ReadonlyArray<string> = [ | |||
| 'Snapper', | |||
| 'Coconut', | |||
| 'Sebastian', | |||
| 'Abby', | |||
| 'Bubbles', | |||
| 'Backhoe', | |||
|
Thanks for the PR! Please make the required changes. Also you need to run |
tonybaloney
approved these changes
Oct 27, 2022
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 10.53% 10.53%
=======================================
Files 5 5
Lines 655 655
Branches 92 92
=======================================
Hits 69 69
Misses 586 586
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a few new pet names of snake, duck, and crab.
Kindly review this pull request and consider it as a hacktoberfest contribution. Please let me know in case any changes are required. Thank You :)