Improve Crowdin integration #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
- Coverage 16.22% 14.07% -2.16%
==========================================
Files 19 17 -2
Lines 1103 746 -357
Branches 159 102 -57
==========================================
- Hits 179 105 -74
+ Misses 916 641 -275
+ Partials 8 0 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The CI failed with the error message: Should I remove this badge? |
tonybaloney
reviewed
Nov 21, 2022
README.md
Outdated
| @@ -17,6 +17,7 @@ | |||
| [](https://marketplace.visualstudio.com/items?itemName=tonybaloney.vscode-pets&WT.mc_id=python-17801-anthonyshaw) | |||
| [](https://marketplace.visualstudio.com/items?itemName=tonybaloney.vscode-pets&WT.mc_id=python-17801-anthonyshaw) | |||
| [](https://marketplace.visualstudio.com/items?itemName=tonybaloney.vscode-pets&WT.mc_id=python-17801-anthonyshaw) | |||
| [](https://crowdin.com/project/vscode-pets) | |||
There was a problem hiding this comment.
Vs code won't allow this to be bundled in the package (see the build error)
There was a problem hiding this comment.
Got it, so I will remove this badge, thank you!
There is another way to add a localized badge - Badges & Status Images
You can install this app and then add the shields-based badge if you don't mind
Or, at least, add the Crowdin project link to the Readme
andrii-bodnar
force-pushed
the
master
branch
from
7e0717b to
8e86aed
Compare
tonybaloney
approved these changes
Nov 21, 2022
tonybaloney
added a commit
that referenced
this pull request
Feb 26, 2023
Improve Crowdin integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
l10n/bundle.l10n.jsonupdatecrowdin/github-actionversionupload_translationssince this option was needed only for initial translations uploading to Crowdin