Fix panel not active message. #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-Hopkinson
commented
Mar 20, 2023
| @@ -187,7 +187,6 @@ export function storeCollectionAsMemento( | |||
| ]); | |||
| } | |||
|
|
|||
| let petPlaygroundStatusBar: vscode.StatusBarItem; | |||
There was a problem hiding this comment.
This is unused as the spawnPetStatusBar is the one actually displayed
Harry-Hopkinson
commented
Mar 20, 2023
| @@ -309,14 +308,6 @@ export function activate(context: vscode.ExtensionContext) { | |||
| }), | |||
| ); | |||
|
|
|||
| // status bar item | |||
There was a problem hiding this comment.
Can remove this as associated with petPlaygroundStatusBar
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
- Coverage 17.00% 16.76% -0.24%
==========================================
Files 21 21
Lines 1147 1145 -2
Branches 154 156 +2
==========================================
- Hits 195 192 -3
+ Misses 946 944 -2
- Partials 6 9 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@tonybaloney this PR is ready |
|
please remove changes to |
|
I have removed the package-lock changes. |
tonybaloney
approved these changes
Jul 4, 2023
|
thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #389