-
-
Notifications
You must be signed in to change notification settings - Fork 58
-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphs for directories don't work in Windows due to path representation #190
Comments
tonybaloney
added a commit
that referenced
this issue
Jul 12, 2023
Fix creating graphs for directories in Windows (fix #190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running
wily graph src/wily/ raw.loc
in Windows results in an empty graph. It turns out that it's due to failing to match paths with different path separators. Specifically, the line below fails to find a value that is present in the revision:wily/src/wily/commands/graph.py
Line 85 in 72c4bb8
To Reproduce
wily build
wily graph src/wily/ raw.loc
Expected behavior
A graph with many lines (for each tracked file in that directory) should open in the browser.
Desktop
Fix
If we convert
path
topathlib.Path(path)
right after the following line, the graph is generated correctly:wily/src/wily/commands/graph.py
Line 77 in 72c4bb8
Once I test that this fix doesn't create issues in Linux, I'll submit a PR.
The text was updated successfully, but these errors were encountered: