Fix aggregation in Windows (fix #210) #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows, aggregation is broken in two ways:
src/
andtest/
in wily's repo, but notsrc/wily/
).This happens because
revision.tracked_files
andrevision.tracked_dirs
store paths with forward slashes, but the paths inresult
use backslashes in Windows. This PR fixes that by converting entries in those lists toPath
s and back tostr
.This fixes the root cause of #210, which initially had a wrong analysis but documents the issue.