add lintpragma for short new argument case

tonyhffong · Oct 3, 2014 · 9aaa480 · 9aaa480 · tonyhffong · Oct 3, 2014
1 parent a3788b9
commit 9aaa480
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/functions.jl b/src/functions.jl
@@ -360,7 +360,9 @@ function lintfunctioncall( ex::Expr, ctx::LintContext )
                 if haskey( ctx.callstack[i].typefields, tname )
                     fields = ctx.callstack[i].typefields[ tname ]
                     if 0 < length( ex.args ) - 1 < length( fields )
-                        msg( ctx, 0, "new is provided with fewer arguments than fields." )
+                        if !in( "Ignore short new argument", ctx.callstack[end].pragmas )
+                            msg( ctx, 0, "new is provided with fewer arguments than fields." )
+                        end
                     elseif length( fields ) < length( ex.args ) - 1
                         msg( ctx, 2, "new is provided with more arguments than fields" )
                     end

diff --git a/test/type.jl b/test/type.jl
@@ -223,3 +223,15 @@ end
 """
 msgs = lintstr(s)
 @assert( isempty( msgs ) ) # ok
+s = """
+type MyType
+    a::Int
+    b::Int
+    function MyType( x )
+        @lintpragma( "Ignore short new argument" )
+        new(x)
+    end
+end
+"""
+msgs = lintstr(s)
+@assert( isempty( msgs ) )