Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #181, #166, #164, code cleanup #208

Merged
merged 4 commits into from
Mar 22, 2017
Merged

Fix #181, #166, #164, code cleanup #208

merged 4 commits into from
Mar 22, 2017

Conversation

TotalVerb
Copy link
Collaborator

@TotalVerb TotalVerb commented Mar 19, 2017 •
edited
Loading

This fixes some bugs at the expense of making #200 far worse. However, having all these false positives simply reveals existing flaws of the linter and makes it easier to fix things later.

Plan to merge this by Wednesday, March 22.

@TotalVerb TotalVerb mentioned this pull request Mar 19, 2017
Closed
@coveralls
Copy link

coveralls commented Mar 19, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 89.791% when pulling 024cc64 on fw/code-cleanup into b2e011d on fw/introduce-E522.

@TotalVerb TotalVerb changed the base branch from fw/introduce-E522 to master March 20, 2017 23:14
TeroFrondelius
TeroFrondelius reviewed Mar 21, 2017
View reviewed changes
Copy link
Contributor

@TeroFrondelius TeroFrondelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried my best to find something to comment, but my competence is not high enough yet. In general really nice work and I am so happy to see Julia's linter development.

@TotalVerb TotalVerb merged commit 8a694b0 into master Mar 22, 2017
@TotalVerb TotalVerb deleted the fw/code-cleanup branch March 22, 2017 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeroFrondelius TeroFrondelius TeroFrondelius left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TotalVerb @coveralls @TeroFrondelius