Merge dev changes into main ready for 1.2.0 release #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only have samples from HW 2 and 4 for now. All other versions will log a warning and use the same ranges as for hw 4 (since that doesn't change the current behaviour for other versions). Fixes #21
Add dev branch to tests github workflow
* Fix deprecates uses of TEMP_CELSIUS * Fix warning about ClimateEntityFeature usage This adds ClimateEntityFeature.TURN_ON and ClimateEntityFeature.TURN_OFF to supported features and disables the backwards compatibility flag related to those. This prevents a warning at initialization. Specific warning is: Entity None (<class 'custom_components.wundasmart.climate.Device'>) implements HVACMode(s): off, auto, heat and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/tonyroberts/hawundasmart/issues * Remove TURN_OFF and TURN_ON flags
When turning on, set temp to the comfort preset temp instead of the current temp + 1.
State and operation_mode are the same thing for the WaterHeaterEntity, and the current operation mode (which self.state returns) has to be an operation mode that can also be selected. When a manual override has been set try to determine the most sensible operation mode to display. Otherwise, use on/off and add those to the list of operation modes allowed. Since we can't turn the water heater on or off without a duration, alias on/off to the longest preconfigured boost/off modes. Fixes #27
Instead of just preventing multiple commands from being sent at once, prevent multiple sessions from being used at the same time. This should prevent the coordinator from polling new values while a command is being sent. Fixes #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.