Value Storage & Options Object #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther than incremented. Included a getValues method that returns a null value rather than a zero for unset timestamps.
…backfilling the value sets when limiting the count
|
Hi @tonyskn, was wondering if you had a chance to review this? I built this feature for the last company that I was with, and now will be using it for another (: Happy to use my fork for now but would love to see this rolled into the npm package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @tonyskn - this pull request adds the ability for the TimeSeries object to record values as well. It is set up to save and retrieve a value recorded during a time slice.
I've been using my own branch for a while and it's been useful to track the current value and history of a key. This is useful for recording things such as historical temperature or # "likes over time" while utilizing a similar get function as the hit counter.
I've also replaced the count param with an opts object (see updated README for more) but set things up so that an integer is still accepted. No existing functions were modified in a way that prevents backwards compatibility.This will add a bit of flexibility in building more features in the future.
Sorry for the messy commits - I'm just running and gunning over here!
Edit - I've also improved the testing coverage and applied it to the new functions as well.