Pin PyYAML 6.0.1 to get around https://github.com/yaml/pyyaml/issues/601 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivian-rook
approved these changes
Jul 19, 2023
|
neat! |
|
I am glad this PR replaced PR #307. This PR (forcing a move to pyyaml > 6.0.0) works because of the yaml/pyyaml#702 workaround (which forces a dependency on Cython < 3.0) that was pulled into the pyyaml 6.0.1 release. yaml/pyyaml#731 is touted as a better fix (not requiring Cython < 3.0) for yaml/pyyaml#601 (and yaml/pyyaml#724 if it gets backported to a 5.x branch). Hopefully it (or something like it) gets applied soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T342144