Replace ignoring all uppercase tags with vtags #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit explicitly defines a list of virtual tags as given in the link given below at this point in time. This includes virtual tags defined for version 2.6.0 (+QUARTER). https://taskwarrior.org/docs/tags.html
ghost
mentioned this pull request
liskin
reviewed
Jul 26, 2020
| @@ -88,7 +88,8 @@ def tw_args_to_kwargs(args): | |||
| elif arg.startswith('+'): | |||
| value = arg[1:] | |||
| # Ignore virtual tags | |||
| if not value.isupper(): | |||
| vtags = ["BLOCKED", "UNBLOCKED", "BLOCKING", "DUE", "DUETODAY", "TODAY", "OVERDUE", "WEEK", "MONTH", "QUARTER", "YEAR", "ACTIVE", "SCHEDULED", "PARENT", "CHILD", "UNTIL", "WAITING", "ANNOTATED", "READY", "YESTERDAY", "TOMORROW", "TAGGED", "PENDING", "COMPLETED", "DELETED", "UDA", "ORPHAN", "PRIORITY", "PROJECT", "LATEST"] | |||
There was a problem hiding this comment.
Would be nice to include a script (a comment is enough probably, doesn't need to actually be a separate file invoked automatically) to generate this list. E.g.
curl --silent --show-error --fail --location \
https://github.com/GothenburgBitFactory/taskwarrior/raw/2.6.0/src/commands/CmdInfo.cpp \
| grep -P -o 'virtualTags \+= "\K\w+'
curl --silent --show-error --fail --location \
https://github.com/GothenburgBitFactory/taskwarrior/raw/2.6.0/doc/man/task.1.in \
| awk '/^ +([A-Z]+) +Matches if the task/ { print $1 }'
Unfortunately the lists don't match as taskwarrior developers aren't very diligent in keeping them in sync despite all the comments reminding them to do so. :-(
I also think this might better go into constants.py, and should be accompanied by a test. :-)
There was a problem hiding this comment.
In constants you can do something like:
TASKWARRIOR_VIRTUAL_TAGS = """
BLOCKED
UNBLOCKED
…
""".split()
to make it easier to paste the output of that command.
Regarding the test: not necessary to add a new test, augmenting an existing one should be good enough I think. :-)
tbabej
force-pushed
the
master
branch
9 times, most recently
from
b549521 to
36652d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit explicitly defines a list of virtual tags as given in the
link given below at this point in time. This includes virtual tags
defined for version 2.6.0 (+QUARTER).
https://taskwarrior.org/docs/tags.html