Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

Fix sub dirs #415

Merged
merged 1 commit into from
Feb 22, 2016
Merged

Fix sub dirs #415

merged 1 commit into from
Feb 22, 2016

Commits on Feb 20, 2016

  1. Fix sub dirs

    TL;DR: We were vendoring too much, this should fix that w/o breaking
    anything (tm).
    
    While working with an internal project and a bunch of go1.6 repos I
    observed `go install ./...` trying to compile stuff that is in the
    vendor directory, but doesn't have all of the deps also vendored. This
    means that they were being copied in incorrectly.
    
    Upon inspection of the code I noticed that vcs files would list all
    files and the sub directories and the dependency checks in fill would
    skip packages based on import prefix, when (AFAICT) it should only skip
    standard and the primary root package importPath.
    
    I also discovered a few tests that appear to be faulty, or exhibit older
    behaviour that I never reviewed.
    
    Basically this commit makes it so that when filling godeps we include
    all dependencies and when saving we don't automatically process sub
    directories of packages unless those sub-directories are also packages
    that are required by the dependency search.
    
    This commit adjusts some tests which I hand validated for behaviour.
    Most tests though are unchanged. Also added positional identifier for
    more save test errors.
    
    More debug added for later operations of save/update.
    Edward Muller committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    0a24d37 View commit details
    Browse the repository at this point in the history