Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

saves the database to current directory versus somewhere better like ~/.vfeed/ #53

Open
qtfkwk opened this issue Feb 16, 2016 · 6 comments

Comments

@qtfkwk
Copy link

qtfkwk commented Feb 16, 2016

The database is saved to and used from the current directory versus somewhere better like ~/.vfeed/. This hampers several things, but most notably putting a symlink somewhere in my path to be able to call/use vfeedcli.py from any directory (cd ~/bin; ln -s path/to/vFeed/vfeedcli.py vfeed) like a system-wide command.

Btw, I have a patch for this already and will sent a PR shortly.

qtfkwk pushed a commit to qtfkwk/vFeed that referenced this issue Feb 16, 2016
@toolswatch
Copy link
Owner

Hi qtfkwk
Let me check it ... thanks for the submission

@toolswatch
Copy link
Owner

It works good.
I will definitely add your fix in the next 0.7 API release

Thanks again qtfkwk

@elnappo
Copy link

elnappo commented Jun 2, 2016

If you want to change this to ~/.vfeed/ please consider the XDG Base Directory Specification.

@agc93
Copy link

agc93 commented Feb 9, 2018

More generally, hard-coding this to ~/.vfeed/ (as #54 does) without any way of overriding that seems to be essentially just as questionably opinionated as hard-coding it to $PWD.

Could it maybe be configurable (perhaps with environment variables) or use the directory where the script is located (meaning you could put it anywhere)?

@qtfkwk
Copy link
Author

qtfkwk commented Feb 9, 2018

Generally agree that ~/.vfeed is as opinionated as $PWD.... also that it doesn’t conform to XDG spec. The level of effort to use an environment variable would not be so high, but would obviously involve a more serious change to the code. In which case, it’d make sense to design it well. I’d suggest a cascade: use the env var or command line option location if set, then perhaps a location in a config file, then fall back to $PWD. Thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants
@toolswatch @elnappo @agc93 @qtfkwk and others