Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context #483

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update context #483

wants to merge 4 commits into from

Conversation

BANG88
Copy link

@BANG88 BANG88 commented Apr 2, 2023

It should return the context...

fixes #403

This change gives us a chance to implement any custom resolver we can.

eg: toonvanstrijp#403
@BANG88
Copy link
Author

BANG88 commented Apr 2, 2023

Sorry. this does not work for I18nService.

@coveralls
Copy link

coveralls commented Jun 24, 2023

Coverage Status

coverage: 90.293% (+0.009%) from 90.284% when pulling de67683 on BANG88:patch-1 into 08b68df on toonvanstrijp:main.

Copy link
Collaborator

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom resolver won't load into i18n module
3 participants