Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: check format & lint in GitHub workflow #670

Merged

Conversation

SchroederSteffen
Copy link
Contributor

@SchroederSteffen SchroederSteffen commented Oct 17, 2024

Description

While preparing another change, I noticed that the lint script doesn't work and that there formatting issues in the code.
Both could be detected if the GitHub workflow test would also lint & check the formatting.
This is added by this PR.

I also added a verify script to be able to easily execute all relevant scripts locally.

To get the build green, we also need to format the code in this PR. I'd suggest to extract these formatting changes into another PR which should be merged before this one (#670).

Additional context

The current lint script eslint '{src,apps,libs,test}/**/*.ts' runs into the following error:

> eslint '{src,apps,libs,test}/**/*.ts'

Oops! Something went wrong! :(

ESLint: 8.49.0

No files matching the pattern "'{src,apps,libs,test}/**/*.ts'" were found.
Please check for typing mistakes in the pattern.

@coveralls
Copy link

Coverage Status

coverage: 90.821% (+0.02%) from 90.805%
when pulling ecce5cf on SchroederSteffen:check-format-lint-github-workflow
into fb35d52 on toonvanstrijp:main.

@SchroederSteffen SchroederSteffen marked this pull request as ready for review October 17, 2024 11:53
@rubiin rubiin merged commit be47f94 into toonvanstrijp:main Oct 17, 2024
3 checks passed
@SchroederSteffen SchroederSteffen deleted the check-format-lint-github-workflow branch October 17, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants