New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

改进事务中的断连重试处理，避免造成数据污染 #234

Merged

liu21st merged 3 commits into top-think:2.0 from NHZEX:patch-8

Feb 19, 2021

Member

NHZEX commented Feb 19, 2021 •

edited

Loading

参考laravel的断连重试关键字进行补充 https://github.com/laravel/framework/blame/8.x/src/Illuminate/Database/DetectsLostConnections.php
~~缩小查询异常的捕获范围到\PDOException ，仅处理可预知的异常（PHP7.4以下版本兼容有问题）~~
在事务中执行查询时不能进行断连重试，防止造成数据污染。
- https://github.com/laravel/framework/blob/3c66f6cda2ac4ee2844a67fc98e676cb170ff4b1/src/Illuminate/Database/Connection.php#L725-L734
- [4.2] Connection::run breaks transaction logic when connection lost inside transaction. laravel/framework#5937
嵌套事务中不能对startTrans的savepoint进行断连重试，防止造成数据污染。
- https://github.com/illuminate/database/blob/8904dfc7ae7b90ac8db5aae04bf8a1e8fcfc7abb/Concerns/ManagesTransactions.php#L131-L144

close #231


          完善事务中的断连重试处理，避免数据污染

f50b9ef

NHZEX marked this pull request as draft

February 19, 2021 06:47

NHZEX added 2 commits

February 19, 2021 17:22


          修复7.4以下版本存在无法把PDO警告转换为异常导致不兼容问题

e2954f2


          修正phpunit兼容性

b53857d

NHZEX marked this pull request as ready for review

February 19, 2021 09:35

liu21st merged commit 123a095 into top-think:2.0

NHZEX deleted the patch-8 branch

March 3, 2021 13:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet