Add recursion_guard_outer() for use in hashing mutable objects. #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,4 +16,29 @@ def abort_on_exception=(value) | |||
| def abort_on_exception | |||
| @abort_on_exception ||= (Thread.abort_on_exception || false) | |||
| end | |||
|
|
|||
| def recursion_guard_outer(identifier, obj, &block) | |||
There was a problem hiding this comment.
This shouldnt' be exposed on the public Thread object.
There was a problem hiding this comment.
Thread.recursion_guard is already exposed, unless there's some magic that limits the visibility of methods implemented in rpython. We need to call this from recursive methods on Array and Hash, so it needs to be visible there at least.
| @@ -1,4 +1,28 @@ | |||
| module Topaz | |||
| def self.recursion_guard_outer(identifier, obj, &block) | |||
There was a problem hiding this comment.
If we're moving stuff anyway, I think we should have all recursion_guard methods on Topaz (or Topaz::Thread, I don't really mind). But with this, we have Topaz.recursion_guard_outer and Thread#recursion_guard - there just shouldn't be two places for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated PR to replace #460.