Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Register username, email, password tooltip. #256

Merged

Conversation

afrisalyp
Copy link

@afrisalyp afrisalyp commented Jul 23, 2019

@anonymousjaggu
Copy link
Collaborator

@asadath1395 please resolve the conficts

@afrisalyp
Copy link
Author

@anonymousjaggu Done.

Copy link
Contributor

@mishacucicea mishacucicea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

topcoder-platform/community-app#2813: For some reason, when you move to email after listening to the email, it will say again the tooltip for username as well, same if you go on password.
topcoder-platform/community-app#2827: The special characters are not read by NVDA screen reader. Seems to work with JAWS
image

@crazyk07 crazyk07 added the P0 label Jul 29, 2019
@afrisalyp
Copy link
Author

topcoder-platform/community-app#2813: For some reason, when you move to email after listening to the email, it will say again the tooltip for username as well, same if you go on password.

Still investigating. The problem only appears on Chrome. There is a weird behaviour causes it.

topcoder-platform/community-app#2827: The special characters are not read by NVDA screen reader. Seems to work with JAWS

I think we don't have control to fix it. NVDA doesn't read the character but JAWS read them.
How should we handle it?

@afrisalyp
Copy link
Author

@mishacucicea
Fixed for

topcoder-platform/community-app#2813: For some reason, when you move to email after listening to the email, it will say again the tooltip for username as well, same if you go on password.

@mishacucicea
Copy link
Contributor

mishacucicea commented Jul 30, 2019

Good work!
If Jaws reads them, it's OK for now.

@nkumar-topcoder
Copy link
Contributor

nkumar-topcoder commented Jul 31, 2019

@mishacucicea can you pls check.
reviewer/QA is having different outcomes, hence on-hold

@mishacucicea
Copy link
Contributor

@nkumar-topcoder Was this merged on dev/prod?

@nkumar-topcoder
Copy link
Contributor

nkumar-topcoder commented Aug 2, 2019

@nkumar-topcoder Was this merged on dev/prod?

@afrisalyp @crazyk07 no this isn't merged, because drasticdpk (deepak) review comment. topcoder-platform/community-app#2813 (comment)

@mishacucicea Can you please review this again and let me know.

@nkumar-topcoder nkumar-topcoder merged commit 96381c0 into topcoder-archive:qa-accessibility Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants