Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Register region #274

Closed
wants to merge 2 commits into from
Closed

Register region #274

wants to merge 2 commits into from

Conversation

afrisalyp
Copy link

@mishacucicea mishacucicea self-assigned this Jul 30, 2019
mishacucicea
mishacucicea reviewed Jul 30, 2019
View reviewed changes
Copy link
Contributor

@mishacucicea mishacucicea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are deleting role="form" and the form label (which was requested as part of another ticket).
Can we have a workaround or another solution to fix the extra form region in mozilla?

@afrisalyp afrisalyp mentioned this pull request Jul 31, 2019
Merged
@afrisalyp
Copy link
Author

@mishacucicea
Fixed by defining aria-label on the form element.
Removing the old "Registration Form" region.

A new PR has been added.
#289

@mishacucicea
Copy link
Contributor

Closing this one as it replaced by PR #289

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mishacucicea mishacucicea mishacucicea left review comments

Assignees

@mishacucicea mishacucicea

Labels
Accessibility Code Review Failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afrisalyp @mishacucicea @crazyk07