This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Add Image Slide Viewer & Image Viewer Header #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| vm.files = [ | ||
| { | ||
| fileId: "abc", | ||
| path: "work/1447877190406-e9c02ed7-00bf-4e52-8c57-4d73fec009ac/9be085da-2013-44e9-8701-507a03c6716e/Screen Shot 2015-12-01 at 1.13.17 PM.png", |
There was a problem hiding this comment.
put files into an example/images and use that instead
| vm.toggleComments = $scope.toggleComments | ||
|
|
||
| vm.generateProfileUrl = (handle) -> | ||
| "https://www.topcoder.com/members/#{handle}" |
There was a problem hiding this comment.
Should this use "API_URL" constant, or do we only every hit topcoder.com for the profiles?
There was a problem hiding this comment.
also, is this for the avatar? if so, the logic should be in the avatar element
|
couldn't the avatar have an option to toggle if its a link or not? |
|
yeah will refactor this later |
samsep
added a commit
that referenced
this pull request
Dec 15, 2015
Add Image Slide Viewer & Image Viewer Header
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @vietnogi @aselbie