[$30] Enabling changing of user mail via Connect-app only by customers

[RishiRajSahu]

Right now the email can't be changed from the Account page of connect as earlier we didn't had support of redirect URL to Connect(or any other custom URL). but with this change (topcoder-archive/ap-member-microservice#198 )in place in member service we are good to go for enabling users to change the email from connect as well.

fyi @acshields @vikasrohit

[maxceem]

@RishiRajSahu

I see that relative change is implemented in Member Service https://github.com/appirio-tech/ap-member-microservice/pull/198/files and merged to DEV.

I've checked worklow which is implemented and it's like this:

• When we update member profile's email we have to define successUrl and failUrl, which is good, so we call update endpoint like this:

  POST https://api.topcoder-dev.com/v3/members/maxceem/?successUrl=connect.topcoder-dev.com%2Fsettings%2Faccount%2Femail-verification%2Fsuccess&failUrl=connect.topcoder-dev.com%2Fsettings%2Faccount%2Femail-verification%2Ffailure
  

  And in the body we are sending member profile with updated email. This part is clear.
• After that backend sends verification email with a link to click which looks like this:

  https://community-app.topcoder-dev.com/v3/members/maxceem/verify?action=verify&token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJyb2xlcyI6WyJhc2RkIiwiY29waWxvdCJdLCJpc3MiOiJodHRwczovL2FwaS50b3Bjb2Rlci1kZXYuY29tIiwiaGFuZGxlIjoibWF4Y2VlbSIsImV4cCI6MTU0NjQ5ODQ4NCwidXNlcklkIjoiNDAwMzUyOTEiLCJpYXQiOjE1NDY0OTc4ODQsImVtYWlsIjoibWF4Y2VlbUBnbWFpbC5jb20iLCJqdGkiOiI4YjQ1MGJmZC05ZTI5LTQwY2ItOWFmYy1iYmQxMDM0YzMwYjQifQ.ar027LU8FnOYIQIW9pCZtzzY2mAuRLI6XeIEjqSulrk&newEmail=maks.m@inbox.ru&oldEmail=maxceem@gmail.com&redirectTo={successUrl}
  

So there are two things:

1. The workflow depends on the community app frontend. As backend sends link which goes to Community App anyway, not to successUrl. And as I see in member service code it's hardcoded. I mean it will be always the link to community app. Looks like the idea is that we will go to commynity app anyway, and community app has to verify email and after community app has to redirect to successUrl which we can define to be the URL in Connect App.
   2.There is issue in backend as successUrl in the link is not replaced with successUrl which I've passed to the update email endpoint.

I'm not sure why such appraoch has been chosen in implementing successUrl/failUrl as we still have to show to our customers Community App instead of directly redirecting them to Connect App. And we are depending on the Commynity App as it has to redirect user to Connect App. So Community App has to implement this feature and has to also work properly and be alive when customers of Connect App change email.

What do you think?

[maxceem]

@RishiRajSahu if you wanna try it yourself here is the branch where I've enabled email changing and added support for successUrl and failUrl https://github.com/appirio-tech/connect-app/tree/feature/account-settings-improvements

[RishiRajSahu]

@maxceem yeah its visible that the baseURL should be replaced with the domain of MemberService only, Let me check the respective changes in community app for this update in member service.

[RishiRajSahu]

fyi @maxceem topcoder-platform/community-app@1bfb71e
topcoder-platform/community-app#1740

[maxceem]

This feature is enabled in https://github.com/appirio-tech/connect-app/tree/feature/account-settings-improvements branch now.

Though looks like there is an issue with member service.

• when I ask to change email

• I get an email with a link to confirm, which looks good:

  

• when I open it in the brwoser I got error:

   {"id":"-20fea014:168579b92c1:-58ec","result":{"success":true,"status":401,"metadata":null,"content":"Valid credentials are required to access this resource."},"version":"v3"}
  

• the token looks also good:

  

[RishiRajSahu]

@maxceem yep I faced this the same day we discussed also notified the member service guys on same, will contact them again to get the update.