[$15] Indicate 'All Project Members' when specified file viewers are removed

[ajefts]

Once a user has uploaded a file and have specified only specific users as the approved viewers, the user needs a way to modify this selection to change the approved file viewers to 'All Project Members.'

Change: In the left sidebar, if a user decides to change the viewers from specified users to 'All Project Members' they can achieve this by deleting the selected specified users under the File Viewers list. If the user deletes all specified viewers the box should a display the following text, "There are no specified file viewers. File will be visible to all project members."

[ajefts]

Link to feature: https://tcprod.productboard.com/feature-board/planning/features/1772896

[maxceem]

@ajefts as per issue desription we only should add a text if there are no members are selected. But issue title says we should add an additional option to the dropdown. Could you please clarify if adding option to dropdown is still requiered.

Regarding the text, if understand this correctly, the best place to show this text is under:

Text style:

    margin: 10px 0;
    line-height: 120%;
    font-size: 12px;

As there is not enough space inside the input where we enter handles and we would loose the hint of what to enter in the field:

[vikasrohit]

@maxceem yes, it seems we need to rephrase the text to accommodate the space.

[maxceem]

@vikasrohit I propose to keep under instead of replacing placeholder. As the placeholder helps users to understand what to enter inside the field. But let me know if you prefer to replace placeholder.

[vikasrohit]

Yep, Agreed. I liked the way you suggested here:

May be we can use some thing like Visible to All. Enter handles to restrict as intermediate solution for placeholder text as well. But let us ask the product.

[RishiRajSahu]

@maxceem To sumup -

1. We need 'All Project Members' as an option in dropdown
2. As vikas in the just preceding comment we are good the way you are suggesting, its only the matter of language we are showing is left so let's keep it as There are no specified file viewers. File will be visible to all project members, we will update the language once we get new update.

[maxceem]

@RishiRajSahu This All Project Members option should be only added to suggestions at the sidebar, but not in the dialog after uploading files, as we have a separate button for it in dialog, right?

• no need to add to suggestions in dialog after a new file uploading
  

• have to add to suggestions when edit file permissions at the sidebar:

  

[RishiRajSahu]

yeah good point, could we have it consistent at both places ? could you quickly edit it via the dev tools how it will look then ?

[maxceem]

Something like this:

Dialog:

Sidebar:

The color is dark, because I had to stop JS so the suggestion is not closed on click outiside.