[$150] Show Created By for files and links list in Assets Library

[vikasrohit]

We should add Created By column for the files and links list in Assets Library

[vikasrohit]

fyi @maxceem

[maxceem]

We can show it for all files, but at the moment we don't have information who created links for the project. We can still show who created links inside posts, as we know who created a post:

Should we update the client-side code to store the information about who created links inside project data?

Also, if we don't write some additional logic server-side, anybody could update this data in the project data. I don't think it's sensitive information, but if we want to make sure that nobody can fake createdBy we should validate project data server-side.

[vikasrohit]

Got it. We are storing the links in a JSON field not as a primary object so we don't have the audit fields there. I think, we should start capturing the audit fields (createdBy, createdAt, updatedBy and updatedAt) inside this JSON for every link to show the details about owner of the link.
I didn't get the validation part though. How can one fake createdBy? Oh, I think you mean that with PATCH request for the project, if we send the bookmarks field as well, it would allow any privileged user to fake the data. Yes, I think we need to do some changes in code for fixing that.

[maxceem]

If we we would store createdBy for links, should we restrict editing links only to users who has created such link as we do for files? If so, should admin still be able to edit any links no matter who created them?

[maxceem]

Sum up:

1. Currently, when we are creating links we store them inside project.bookmarks JSON in the next format:

   

   Additionally, we should add the next properties for each link:

   • createdAt - creation date in format 2019-09-05T05:52:21.240Z
   • createdBy - id of the user who created the link in format 123456789 (number)
   • updatedAt - should be updated when we create and update links
   • updatedBy - should be updated when we create and update links

2. Add column Created By on Assets Library tab see demo project

   Show user <FirstName> <LastName> or <userHandle> with the tooltip, the same way as we do in project list see screenshot.

   We would have to load user details by userId for all the users which are listed in createdBy or updatedBy, but only if information for them has not been loaded yet. See how we do it on the project listing page.

Note. That some files and links comes from the posts. In such cases we should use createdBy from the post from which we extracted the file or link.