Skip to content

Conversation

@maxceem
Copy link
Collaborator

@maxceem maxceem commented Oct 4, 2017

Fix for issue #1196

  • webpack updated to v3.6.0 and webpack-dev-server to v2.9.1

  • extract-text-webpack-plugin replaced with extract-css-chunks-webpack-plugin from the fork of birdofpreyru
    Seeing that webpack-config project has been using as a kind of universal config, there was a lot of stuff which is not used by connect-app, so I removed it:

  • removed support for jade-like formats as they are not used in in the project

  • removed --tc argument from webpack command, haven't found any usage in config

  • removed --silent param inside webpack config as haven't found any usage in config

  • removed --test param inside webpack config as webpack was never called with this param

  • removed DedupePlugin

  • removed __MOCK__ variable from DefinePlugin as it never appears in the project

  • npm run test and npm run test:watch don't work as it was before

  • there is one small issue after migration:
    When we run the project in dev mode with hot reloading and make first change, hot reloading works, but first time it triggers components remount, next reloads don't
    it could be connected with the fact that react-hot-loader doesn't fully support react-router@3,
    migration to react-router@4 probably can solve it

@gondzo
Copy link
Collaborator

gondzo commented Oct 7, 2017

@vic-topcoder @vikasrohit @mtwomey
Looks like we need to update react-router from 3 to 4 to complete this migration to webpack 3 (otherwise hot reload doesn't work). IMO we shouldn't merge this until we have hot reload working properly. Any ideas ?

@mtwomey
Copy link
Contributor

mtwomey commented Oct 12, 2017

@gondzo Can we do a paid task to do the upgrade for react-router?

@gondzo gondzo merged commit 64a0286 into topcoder-archive:test02 Oct 13, 2017
@gondzo
Copy link
Collaborator

gondzo commented Oct 13, 2017

Sure. Merging this one to test02 and I'll merge to dev once react-router is updated.

@kevinkid
Copy link
Contributor

Al be happy to work on it as private task .

@gondzo
Copy link
Collaborator

gondzo commented Oct 13, 2017

It's assigned to a different member already.

@kevinkid
Copy link
Contributor

cool thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants