Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1196
webpack updated to v3.6.0 and webpack-dev-server to v2.9.1
extract-text-webpack-pluginreplaced withextract-css-chunks-webpack-pluginfrom the fork of birdofpreyruSeeing that webpack-config project has been using as a kind of universal config, there was a lot of stuff which is not used by connect-app, so I removed it:
removed support for
jade-like formats as they are not used in in the projectremoved
--tcargument from webpack command, haven't found any usage in configremoved
--silentparam inside webpack config as haven't found any usage in configremoved
--testparam inside webpack config as webpack was never called with this paramremoved
DedupePluginremoved
__MOCK__variable fromDefinePluginas it never appears in the projectnpm run testandnpm run test:watchdon't work as it was beforethere is one small issue after migration:
When we run the project in dev mode with hot reloading and make first change, hot reloading works, but first time it triggers components remount, next reloads don't
it could be connected with the fact that react-hot-loader doesn't fully support react-router@3,
migration to react-router@4 probably can solve it