Skip to content

Conversation

@afrisalyp
Copy link
Contributor

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @afrisalyp generally works good.

There is just one case to handle:

  • when we edit some field button becomes active as expected
  • after I click Close button - so I'm not saving what I edited
  • when I open the form again, all the values are reset like from the beginning without my edits, but the button to update is active, it should be disabled, as no values are changed

See screencast https://monosnap.com/file/1kyGVb9mQq3laMB7i4H5xjKuxcG1i5

Also, I've added one more comment regarding performance, please have a look.

@afrisalyp
Copy link
Contributor Author

@maxceem,
I'm working on the issue.
And I've also replied the comment on the line.

@afrisalyp
Copy link
Contributor Author

Hi @maxceem
Please take a look for the new commit.
It resolves the issues of the resetting the state and the performance issue.

Thanks.

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrisalyp your approach fixes a possible performance issue. And everything works good.
Thank you!

@maxceem maxceem merged commit 967f3e7 into topcoder-archive:cf14 Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants