Gauravgautam #2861
Merged
Gauravgautam #2861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create test cases which would break our expression evaluation function
maxceem
approved these changes
Feb 27, 2019
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
Great set of tests!
Thank you @gautam1168.
PS. we can use throw in lowercase to avoid lint errors. All of these are synonyms:
Contributor
Author
|
Ah I see. I was not aware of the lower case throw.
…On Wed, 27 Feb 2019, 07:48 maxceem, ***@***.***> wrote:
Merged #2861 <#2861> into
cf15-evaluate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2861 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJD0XOLOsnvSLoTSoHoHFxSn3BFvhxZCks5vResLgaJpZM4bRpEC>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for the operators that were not tested already.
There are 32 failing test cases and 81 passing ones. The failing test cases should pass if the evaluate function is supposed to work like js engine in chrome.
The lint shows 12 errors but those are because of the
Throwfunction ofchai. I cannot change that.