[HOTFIX] [PROD] Filter skills ignore case of categories #3186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kill categories which come from skill API
vikasrohit
approved these changes
Jul 17, 2019
vikasrohit
pushed a commit
that referenced
this pull request
Jul 18, 2019
* [HOTFIX] [PROD] Filter skills ignore case of categories (#3186) * fix: filter skills inside SkillsQuestion component ignoring case of skill categories which come from skill API * improve fix to make sure it's not broken if data from skills API is not complete * Github issue#3189, Unable to activate a phase without explicitly setting start date to today's date — Calculate the end date as well when activating the phase
vikasrohit
pushed a commit
that referenced
this pull request
Jul 18, 2019
* [HOTFIX] [PROD] Filter skills ignore case of categories (#3186) * fix: filter skills inside SkillsQuestion component ignoring case of skill categories which come from skill API * improve fix to make sure it's not broken if data from skills API is not complete * Github issue#3189, Unable to activate a phase without explicitly setting start date to today's date — Calculate the end date as well when activating the phase * Fixed bug with last hot fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: filter skills inside SkillsQuestion component ignoring case of skill categories which come from skill API