-
Notifications
You must be signed in to change notification settings - Fork 136
issue 3206 fix #3307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 3206 fix #3307
Conversation
maxceem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current fix doesn't work for me.
Confirmation dialog should be opened under the status select. And confirmation dialog should "push" content bellow when opened, not shown on the top. See task description #3206 (comment)
Let me know if you would like to try to complete it, or open this issue for pick up.
|
@maxceem I will complete it |
|
@maxceem PR updated and it will be shown below dropdown "Project is active". Kindly provide feedback if any because current behaviour is that when "cancelled" is clicked then dropown list disappears and dialog appears. so I am not keeping dropdown list visible. It will be hidden as current behaviour. just dialog will appear at red line mentioned by you in above comment |
maxceem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right @PrakashDurlabhji dropdown should be hidden when we click cancelled.
Now the confirmation dialog is shown under the dropdown, but it is shown on top for members. What we want here is that this confirmation dialog is inserted inside left sidebar so the content bellow it is pushed down:
So when confirmation dialog is opened, everything else should be still visible.
|
@maxceem updating |
|
@maxceem updated |
|
@PrakashDurlabhji I see 2 your comments #3307 (comment) and #3307 (comment) that this PR has been updated, but there are no new commits. Would you be able to fix this PR as per my comment above #3307 (review) or should I open this issue for pick up? |
|
@maxceem it is completed now |
|
@maxceem code update done and working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PrakashDurlabhji. The confirmation dialog now is shown as per requirements.
|
@maxceem PR update done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PrakashDurlabhji there are two changes which I'm not sure if they are required or no.
|
@PrakashDurlabhji there are two changes which I'm not sure if they are required or no. Could you please have a look on the comment above #3307 (review) |
|
@PrakashDurlabhji do you have update here? |
|
@maxceem change 1 required to keep it center. |
|
@maxceem ready |
maxceem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for update @PrakashDurlabhji. Works good.






No description provided.