-
Notifications
You must be signed in to change notification settings - Fork 136
Update Invited Registered User Workflow #3311 #3335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Invited Registered User Workflow #3311 #3335
Conversation
Update Invited Registered User Workflow topcoder-archive#3311
add new action for invite fail
maxceem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @suppermancool. Sorry for the delay with review.
There are a few issues I've noticed.
-
If I just open any project after several second I see an error page. For example if open project http://local.topcoder-dev.com:3000/projects/8369 with
pshah_manageruser and wait around 10 seconds. See demo video https://monosnap.com/file/5kso0uGG9G3oBZk5cCyP0we5tMhUZy. -
If I've already joined the project and use link like
http://local.topcoder-dev.com:3000/projects/8369?invitation=acceptorhttp://local.topcoder-dev.com:3000/projects/8369?invitation=declineit works good now and we just see the project. But also we have to remove?invitation=...from the URL. -
In case user accepts invitation it works good and I can see that URL is changed to the URL without
?invitation=.... But the URL with?invitation=...stays in history, so if we press back, we will go the URL with?invitation=.... But when we press back we have to go to previous page. So after we accept invitation we have toreplaceURL with the new one instead of going to the next page so there is now URL with?invitation=...in the browser history:

- I think we have to use
history.replaceinstead ofhistory.pushfor this.
NOTE. In case of
declinewe should go to the next page. SodeclineURL should stays in the browser history. - I think we have to use
fix feedback
remove promise for invite fail
|
@maxceem all done in the latest commit |
maxceem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suppermancool all works great now except of case where the request to accept/decline invitation fails on the server.
To force failing of invitation processing on the server-side I've updated acceptOrRefuseInvite method, so it send a wrong invitation status to the server:
Now if I follow link with automatic invite declining it sends request to decline invitation in the infinite loop, see the demo video.
The same thing happens if I use link for automatic invitation acceptance.
… on the server." This reverts commit c70f527.
maxceem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @suppermancool.
Now there is no infinite loop anymore, but the error which is shown when there is error on the fail during accepting/declining invitation is not correct. Currently, it shows error 404 that page cannot be found, but we should show the error that we cannot accept/decline invitation. When we click Copy error details link, there should be detailed error from the server.
fix show error message for invite fail
|
@maxceem done in the latest commit |
maxceem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @suppermancool. Works good.


Update Invited Registered User Workflow #3311