Skip to content
Merged

CF19 #3340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
1e4171d
Update ProjectInfoContainer.scss
PrakashDurlabhji Sep 19, 2019
9ea5266
Need red cue for new file or link uploaded for the project #3274
suppermancool Sep 19, 2019
c93d020
Messaging on mobile #3213
suppermancool Sep 19, 2019
f2f138d
403 in suggesting users to the Customers while adding members to the …
suppermancool Sep 19, 2019
fabe610
use component tool tip
suppermancool Sep 19, 2019
9755618
Fix UI for REF on the project details page #3212
suppermancool Sep 19, 2019
9914ec2
remove manage button and rename invitePeople button
sahil143 Sep 19, 2019
9002431
Merge pull request #5 from appirio-tech/cf19
rashmi73 Sep 19, 2019
c4498a8
keep entered data if error occurs during entity updating #3179
suppermancool Sep 19, 2019
fe250b1
bug #3273 Show Created By for files and links list in Assets Library
jacky-zhangjb Sep 19, 2019
7344f93
Merge branch 'cf19' into issue-3212
suppermancool Sep 20, 2019
a4691ad
show tooltip component
suppermancool Sep 20, 2019
fb19c83
fix tooltip width
suppermancool Sep 20, 2019
b1e4c74
remove redundant code
suppermancool Sep 20, 2019
2f6108a
Error message has been already shown by alert popup.
gets0ul Sep 20, 2019
850bda7
bug #3273 Show Created By for files and links list in Assets Library 2
jacky-zhangjb Sep 21, 2019
1ddc7b8
Merge branch 'cf19' into issue-3274
suppermancool Sep 21, 2019
89fda27
fix notification type and remove console.log
suppermancool Sep 21, 2019
18ac173
Merge pull request #3308 from suppermancool/issue-3274
maxceem Sep 21, 2019
a6e7b44
Merge branch 'cf19' into issue-3213
suppermancool Sep 21, 2019
f68bd57
update component use CSS Modules
suppermancool Sep 21, 2019
f589c53
Merge pull request #3313 from suppermancool/issue-3213
maxceem Sep 21, 2019
da301d5
Merge pull request #3315 from suppermancool/issue-3212
maxceem Sep 21, 2019
c5c9ce4
Merge branch 'cf19' into issue-3225
suppermancool Sep 21, 2019
160de9e
avoid calling action to clear suggestions
suppermancool Sep 21, 2019
1e82f3a
Merge pull request #6 from appirio-tech/cf19
rashmi73 Sep 21, 2019
bf5fed0
issue 3210 fix
rashmi73 Sep 21, 2019
9a4a218
Update ProjectStatusChangeConfirmation.scss
PrakashDurlabhji Sep 21, 2019
071ec4c
Merge pull request #6 from appirio-tech/cf19
PrakashDurlabhji Sep 21, 2019
20dd9f5
Update project.js
PrakashDurlabhji Sep 21, 2019
d16dd9b
bug #3273 Show Created By for files and links list in Assets Library 3
jacky-zhangjb Sep 22, 2019
dc47734
Merge pull request #3314 from suppermancool/issue-3225
maxceem Sep 22, 2019
bd5baf3
Merge pull request #7 from appirio-tech/cf19
rashmi73 Sep 22, 2019
35f48e3
Merge pull request #7 from appirio-tech/cf19
PrakashDurlabhji Sep 22, 2019
843a30a
issue 3297 fix
PrakashDurlabhji Sep 22, 2019
98a0489
remove view button from TeamManagement
sahil143 Sep 22, 2019
1c4cf16
Merge pull request #3317 from sahil143/issue-3294
maxceem Sep 22, 2019
119ff15
show loading when saving
suppermancool Sep 22, 2019
cde6979
Merge pull request #8 from appirio-tech/cf19
rashmi73 Sep 22, 2019
6722b40
issue 3303 fix
rashmi73 Sep 22, 2019
3940d0a
Merge pull request #3318 from suppermancool/issue-3179
maxceem Sep 23, 2019
df99c80
Merge pull request #3331 from suppermancool/issue-3211
maxceem Sep 23, 2019
00d7a35
Add usePortal=true flag to the tooltip in dropdown's option to indica…
gets0ul Sep 23, 2019
d897120
issue 3329 fix
rashmi73 Sep 23, 2019
554111c
Merge branch 'dev' into cf19
maxceem Sep 24, 2019
1ff7085
Merge pull request #3324 from PrakashDurlabhji/issue_3207
maxceem Sep 24, 2019
e7048a9
Merge pull request #10 from appirio-tech/cf19
rashmi73 Sep 24, 2019
f65959a
issue 3297 minor modif
PrakashDurlabhji Sep 24, 2019
23ad36e
Merge pull request #3327 from PrakashDurlabhji/issue_3297
maxceem Sep 24, 2019
dfbc81d
Fix lint errror.
gets0ul Sep 24, 2019
1310070
issue 3210 patch
rashmi73 Sep 24, 2019
3f8f1da
issue 3210 lint fix
rashmi73 Sep 24, 2019
9b0a7ca
Merge pull request #3332 from gets0ul/issue-3215
maxceem Sep 24, 2019
da95bbd
Set error flag as false as it is actually not needed.
gets0ul Sep 24, 2019
825e71a
fix: lint
maxceem Sep 24, 2019
082a49f
Merge pull request #3333 from rashmi73/issue_3329
maxceem Sep 24, 2019
d5eb611
issue 3303 patch
rashmi73 Sep 24, 2019
a88b4fc
Merge pull request #3328 from rashmi73/issue_3303
maxceem Sep 24, 2019
22d70db
Update FormFieldDate.jsx
rashmi73 Sep 24, 2019
5bf5132
remove error
gets0ul Sep 24, 2019
8e4d9de
Update ProjectStatusChangeConfirmation.scss
PrakashDurlabhji Sep 24, 2019
3000c63
Update ProjectStatus.scss
PrakashDurlabhji Sep 24, 2019
2050c58
Merge pull request #3321 from gets0ul/issue-3180
maxceem Sep 24, 2019
654f6ef
Update ProjectStatus.scss
PrakashDurlabhji Sep 25, 2019
eed1d81
Update ProjectInfoContainer.scss
PrakashDurlabhji Sep 25, 2019
ca9f5c3
Update ProjectStatusChangeConfirmation.scss
PrakashDurlabhji Sep 25, 2019
074f8e2
bug #3273 Show Created By for files and links list in Assets Library 4
jacky-zhangjb Sep 29, 2019
568c5f4
bug #3273 Show Created By for files and links list in Assets Library 5
jacky-zhangjb Sep 29, 2019
865349c
bug #3273 Show Created By for files and links list in Assets Library 6
jacky-zhangjb Sep 30, 2019
ca65dce
Merge pull request #3320 from jankyzhang/cf19
maxceem Sep 30, 2019
7eb7837
issue 3210 minor fix
rashmi73 Sep 30, 2019
b3cf374
Merge pull request #3323 from rashmi73/issue_3210
maxceem Sep 30, 2019
5149a08
fix: lint
maxceem Sep 30, 2019
64aabb7
Merge branch 'dev' into cf19
maxceem Sep 30, 2019
9635f9a
bug #3273 Created By and Created At improvement
jacky-zhangjb Sep 30, 2019
363e1ea
Update ProjectStatusChangeConfirmation.scss
PrakashDurlabhji Sep 30, 2019
ca44a54
Update ProjectStatusChangeConfirmation.jsx
PrakashDurlabhji Sep 30, 2019
bc2c16a
Merge pull request #3307 from PrakashDurlabhji/issue_3206
maxceem Oct 1, 2019
3ca36c3
Merge pull request #3341 from jankyzhang/cf19-2
maxceem Oct 1, 2019
c358290
feat: show Modified date for folders on Assets Library page
maxceem Oct 1, 2019
d90500a
Lint-fix
RishiRajSahu Oct 1, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/components/AssetsLibrary/FilesGridView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import DeleteFileLinkModal from '../LinksMenu/DeleteFileLinkModal'
import EditFileAttachment from '../LinksMenu/EditFileAttachment'
import SubFolder from './SubFolder'
import ItemOperations from './ItemOperations'
import UserTooltip from '../User/UserTooltip'

import FolderIcon from '../../assets/icons/v.2.5/icon-folder-small.svg'

Expand All @@ -28,6 +29,7 @@ const FilesGridView = ({
title,
selectedUsers,
onAddAttachment,
assetsMembers,
isSharingAttachment,
discardAttachments,
onChangePermissions,
Expand Down Expand Up @@ -78,6 +80,7 @@ const FilesGridView = ({
link={ subFolderContent }
renderLink={ renderLink }
goBack={goBack}
assetsMembers={assetsMembers}
onDeletePostAttachment={onDeletePostAttachment}
loggedInUser={loggedInUser}
formatModifyDate={formatModifyDate}
Expand All @@ -99,6 +102,7 @@ const FilesGridView = ({
<li styleName="assets-gridview-header" key="assets-gridview-header">
<div styleName="flex-item-title item-type">Type</div>
<div styleName="flex-item-title item-name">Name</div>
<div styleName="flex-item-title item-created-by">Created By</div>
<div styleName="flex-item-title item-modified">Modified</div>
<div styleName="flex-item-title item-action"/>
</li>
Expand All @@ -119,12 +123,22 @@ const FilesGridView = ({
const canEdit = `${link.createdBy}` === `${loggedInUser.userId}`

const changeSubFolder = () => onChangeSubFolder(link)
const owner = _.find(assetsMembers, m => m.userId === _.parseInt(link.createdBy))

if (Array.isArray(link.children) && link.children.length > 0) {
return (
<li styleName="assets-gridview-row" onClick={changeSubFolder} key={'assets-gridview-folder-' + idx}>
<div styleName="flex-item item-type"><FolderIcon /></div>
<div styleName="flex-item item-name hand"><p>{formatFolderTitle(link.title)}</p></div>
<div styleName="flex-item item-created-by">
{!owner && (<div className="user-block txt-italic">Unknown</div>)}
{owner && (
<div className="spacing">
<div className="user-block">
<UserTooltip usr={owner} id={idx} size={35} />
</div>
</div>)}
</div>
<div styleName="flex-item item-modified">{formatModifyDate(link)}</div>
<div styleName="flex-item item-action"/>
</li>)
Expand Down Expand Up @@ -161,6 +175,15 @@ const FilesGridView = ({
<img width={42} height={42} src={iconPath} />
</div>
<div styleName="flex-item item-name"><p>{renderLink(link)}</p></div>
<div styleName="flex-item item-created-by">
{!owner && (<div className="user-block txt-italic">Unknown</div>)}
{owner && (
<div className="spacing">
<div className="user-block">
<UserTooltip usr={owner} id={idx} size={35} />
</div>
</div>)}
</div>
<div styleName="flex-item item-modified">{formatModifyDate(link)}</div>
<div styleName="flex-item item-action">
{canEdit && (
Expand Down
9 changes: 8 additions & 1 deletion src/components/AssetsLibrary/GridView.scss
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
}
}

.item-modified {
.item-modified, .item-created-by {
-webkit-box-flex: 0;
-ms-flex: none;
flex: none;
Expand Down Expand Up @@ -134,4 +134,11 @@

.assets-gridview-container-active {
position: relative;
}

:global {
.user-block .tooltip-container {
text-align: left;
line-height: 20px;
}
}
28 changes: 27 additions & 1 deletion src/components/AssetsLibrary/LinksGridView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import DeleteLinkModal from '../LinksMenu/DeleteLinkModal'
import EditLinkModal from '../LinksMenu/EditLinkModal'
import SubFolder from './SubFolder'
import ItemOperations from './ItemOperations'
import UserTooltip from '../User/UserTooltip'

import FolderIcon from '../../assets/icons/v.2.5/icon-folder-small.svg'
import LinkIcon from '../../assets/icons/link-12.svg'
Expand All @@ -28,6 +29,7 @@ const LinksGridView = ({
title,
formatModifyDate,
formatFolderTitle,
assetsMembers,
}) => {
const renderLink = (link) => {
if (link.onClick) {
Expand Down Expand Up @@ -58,8 +60,9 @@ const LinksGridView = ({
link={ subFolderContent }
renderLink={ renderLink }
goBack={goBack}
formatModifyDate={formatModifyDate}
assetsMembers={assetsMembers}
isLinkSubFolder
formatModifyDate={formatModifyDate}
/>)}
{(!subFolderContent) && (
<div styleName={cn({'assets-gridview-container-active': (linkToEdit >= 0 || linkToDelete >= 0)}, '')}>
Expand All @@ -69,6 +72,7 @@ const LinksGridView = ({
<li styleName="assets-gridview-header" key="assets-gridview-header">
<div styleName="flex-item-title item-type">Type</div>
<div styleName="flex-item-title item-name">Name</div>
<div styleName="flex-item-title item-created-by">Created By</div>
<div styleName="flex-item-title item-modified">Modified</div>
<div styleName="flex-item-title item-action"/>
</li>
Expand All @@ -87,12 +91,24 @@ const LinksGridView = ({
const onEditCancel = () => onEditIntent(-1)
const handleEditClick = () => onEditIntent(idx)
const changeSubFolder = () => onChangeSubFolder(link)
const owner = _.find(assetsMembers, m => m.userId === _.parseInt(link.createdBy))

if (Array.isArray(link.children) && link.children.length > 0) {
return (
<li styleName="assets-gridview-row" onClick={changeSubFolder} key={'assets-gridview-folder-' + idx}>
<div styleName="flex-item item-type"><FolderIcon /></div>
<div styleName="flex-item item-name hand"><p>{formatFolderTitle(link.title)}</p></div>
<div styleName="flex-item item-created-by">
{!owner && !link.createdBy && (<div className="user-block">—</div>)}
{!owner && link.createdBy !== 'CoderBot' && (<div className="user-block txt-italic">Unknown</div>)}
{!owner && link.createdBy === 'CoderBot' && (<div className="user-block">CoderBot</div>)}
{owner && (
<div className="spacing">
<div className="user-block">
<UserTooltip usr={owner} id={idx} size={35} />
</div>
</div>)}
</div>
<div styleName="flex-item item-modified">{formatModifyDate(link)}</div>
<div styleName="flex-item item-action"/>
</li>)
Expand All @@ -119,6 +135,16 @@ const LinksGridView = ({
<li styleName="assets-gridview-row" key={'assets-gridview-item-' +idx}>
<div styleName="flex-item item-type"><LinkIcon/></div>
<div styleName="flex-item item-name"><p>{renderLink(link)}</p></div>
<div styleName="flex-item item-created-by">
{!owner && !link.createdBy && (<div className="user-block">—</div>)}
{!owner && link.createdBy && (<div className="user-block txt-italic">Unknown</div>)}
{owner && (
<div className="spacing">
<div className="user-block">
<UserTooltip usr={owner} id={idx} size={35} />
</div>
</div>)}
</div>
<div styleName="flex-item item-modified">{formatModifyDate(link)}</div>
<div styleName="flex-item item-action">
{(canEdit || canDelete) && (
Expand Down
19 changes: 17 additions & 2 deletions src/components/AssetsLibrary/SubFolder.jsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import React from 'react'
import PropTypes from 'prop-types'
import _ from 'lodash'
import cn from 'classnames'

import DeleteFileLinkModal from '../LinksMenu/DeleteFileLinkModal'
import ItemOperations from './ItemOperations'
import UserTooltip from '../User/UserTooltip'
import FolderIcon from '../../assets/icons/v.2.5/icon-folder-small.svg'

import './GridView.scss'
Expand Down Expand Up @@ -54,8 +56,9 @@ class SubFolder extends React.Component {
}

render() {
const { link, renderLink, goBack, formatModifyDate, isLinkSubFolder } = this.props
const { link, renderLink, goBack, formatModifyDate, isLinkSubFolder, assetsMembers } = this.props
const { linkToDelete } = this.state

return (
<div styleName={cn({'assets-gridview-container-active': (linkToDelete >= 0)}, '')}>
{(linkToDelete >= 0) && <div styleName="assets-gridview-modal-overlay"/>}
Expand All @@ -64,17 +67,20 @@ class SubFolder extends React.Component {
<li styleName="assets-gridview-header" key="assets-gridview-header">
<div styleName="flex-item-title item-type">Type</div>
<div styleName="flex-item-title item-name">Name</div>
<div styleName="flex-item-title item-created-by">Created By</div>
<div styleName="flex-item-title item-modified">Modified</div>
<div styleName="flex-item-title item-action"/>
</li>
<li styleName="assets-gridview-row" key="assets-gridview-subfolder" onClick={goBack}>
<div styleName="flex-item item-type"><FolderIcon /></div>
<div styleName="flex-item item-name hand">..</div>
<div styleName="flex-item item-created-by"/>
<div styleName="flex-item item-modified"/>
<div styleName="flex-item item-action"/>
</li>
{
link.children.map((childLink, i) => {
const owner = _.find(assetsMembers, m => m.userId === _.parseInt(childLink.createdBy))
if (linkToDelete === i) {
return (
<li styleName="delete-confirmation-modal" key={'delete-confirmation-post-attachment-' + i}>
Expand All @@ -100,6 +106,16 @@ class SubFolder extends React.Component {
return (<li styleName="assets-gridview-row" key={`childlink-${childLink.address}-${i}`}>
<div styleName="flex-item item-type"><img width={42} height={42} src={ iconPath } /></div>
<div styleName="flex-item item-name"><p>{renderLink(childLink)}</p></div>
<div styleName="flex-item item-created-by">
{!owner && childLink.createdBy !== 'CoderBot' && (<div className="user-block txt-italic">Unknown</div>)}
{!owner && childLink.createdBy === 'CoderBot' && (<div className="user-block">CoderBot</div>)}
{owner && (
<div className="spacing">
<div className="user-block">
<UserTooltip usr={owner} id={i} size={35} />
</div>
</div>)}
</div>
<div styleName="flex-item item-modified">{formatModifyDate(childLink)}</div>
<div styleName="flex-item item-action">
{childLink.deletable && this.hasAccess(childLink.createdBy) && (
Expand All @@ -123,7 +139,6 @@ SubFolder.propTypes = {
onDeletePostAttachment: PropTypes.func,
goBack: PropTypes.func.isRequired,
loggedInUser: PropTypes.object,
formatModifyDate: PropTypes.func.isRequired,
}

export default SubFolder
9 changes: 5 additions & 4 deletions src/components/Footer/Footer.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ require('./Footer.scss')
const Footer = () => {
const currentYear = moment().format('YYYY')
const otherNavigationItems = [
{img: '', text: 'About', link: 'https://www.topcoder.com/about/', target: '_blank'},
{img: '', text: 'Contact us', link: 'https://www.topcoder.com/contact/', target: '_blank'},
{img: '', text: 'Privacy', link: 'https://www.topcoder.com/community/how-it-works/privacy-policy/', target: '_blank'},
{img: '', text: 'Terms', link: 'https://connect.topcoder.com/terms', target: '_blank'}
{img: '', text: 'About', link: 'https://www.topcoder.com/company/', target: '_blank'},
{img: '', text: 'Contact us', link: 'https://www.topcoder.com/contact-us/', target: '_blank'},
{img: '', text: 'Privacy', link: 'https://www.topcoder.com/privacy-policy/', target: '_blank'},
{img: '', text: 'Terms', link: 'https://connect.topcoder.com/terms', target: '_blank'},
{img: '', text: 'Our Process', link: 'https://www.topcoder.com/solutions/how-it-works/', target: '_blank'}
]
const isProjectDetails = /projects\/\d+/.test(window.location.pathname)
const isCreateProject = window.location.pathname.startsWith(NEW_PROJECT_PATH)
Expand Down
5 changes: 3 additions & 2 deletions src/components/FooterV2/FooterV2.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@ import './FooterV2.scss'
const FooterV2 = () => (
<div className="footer-v2">
<ul className="footer-links">
<li><a href="https://www.topcoder.com/about/" target="_blank">About</a></li>
<li><a href="https://www.topcoder.com/contact/" target="_blank">Contact us</a></li>
<li><a href="https://www.topcoder.com/company/" target="_blank">About</a></li>
<li><a href="https://www.topcoder.com/contact-us/" target="_blank">Contact us</a></li>
<li><a href="https://www.topcoder.com/community/how-it-works/privacy-policy/" target="_blank">Privacy</a></li>
<li><a href="https://connect.topcoder.com/terms" target="_blank">Terms</a></li>
<li><a href="https://www.topcoder.com/solutions/how-it-works/" target="_blank">Our Process</a></li>
</ul>
<div className="footer-copyright">
© Topcoder { moment().format('YYYY') }
Expand Down
10 changes: 6 additions & 4 deletions src/components/MenuItem/MenuItem.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ const MenuItem = ({
isAccordionOpen,
onAccordionToggle,
match,
wrapperClass
wrapperClass,
toolTipText,
}) => {
const matchedPath = match && match.path
const isChildActive = children && some(children, c => c.to === matchedPath)
Expand All @@ -47,7 +48,7 @@ const MenuItem = ({
{label}
</span>
<span styleName="right">
{!!count && <NotificationBadge count={count} />}
{!!count && <NotificationBadge count={count} text={toolTipText} />}
</span>
</NavLink>
)}
Expand All @@ -68,7 +69,7 @@ const MenuItem = ({
{label}
</span>
<span styleName="right">
{!!count && <NotificationBadge count={count} />}
{!!count && <NotificationBadge count={count} text={toolTipText} />}
</span>

<ArrowUpIcon className={styles.arrowUpIcon} />
Expand Down Expand Up @@ -100,7 +101,8 @@ MenuItem.propTypes = {
children: PT.array,
isAccordionOpen: PT.bool,
onAccordionToggle: PT.func,
wrapperClass: PT.string
wrapperClass: PT.string,
toolTipText: PT.string,
}

export default withRouter(MenuItem)
3 changes: 2 additions & 1 deletion src/components/MenuList/MenuList.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ MenuList.propTypes = {
to: PT.string.isRequired,
Icon: PT.func.isRequired,
exact: PT.bool,
isActive: PT.func
isActive: PT.func,
toolTipText: PT.string
})
),
onAccordionToggle: PT.func.isRequired
Expand Down
8 changes: 8 additions & 0 deletions src/components/MobilePage/MobilePage.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@
overflow: hidden;
overflow-y: scroll;
}

.mobile-page-gateway {
z-index: 10000;
position: absolute;
top: 0;
left: 0;
width: 100%;
}
}

.container {
Expand Down
25 changes: 13 additions & 12 deletions src/components/NotificationBadge/NotificationBadge.scss
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
@import '~tc-ui/src/styles/tc-includes';

.badge {
display: inline-flex;
background: $tc-red-70;
color: white;
@include roboto-bold;
border-radius: 100%;
height: 17px;
line-height: 17px;
justify-content: center;
align-items: center;
width: 17px;
font-size: 11px;
}
display: inline-flex;
background: $tc-red-70;
color: white;
@include roboto-bold;
border-radius: 100%;
line-height: 17px;
justify-content: center;
align-items: center;
min-width: 17px;
min-height: 17px;
padding: 0 2px;
font-size: 11px;
}
Loading